Re: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation

["Lukas Wagner" <l.wagner@proxmox.com>]

On Mon Jul 28, 2025 at 8:46 AM CEST, Christian Ebner wrote:
> This patches aim to increase usability for the user by allowing to list
> accessible buckets during datastore creation.
>
> For this, the proxmox s3 client is extended by the list buckets method, fetching
> accessible buckets from the s3 api. This requires the client instantiation to be
> possible without the bucket name, making it therefore optional. Further, the
> regex for the config endpoint url must be restricted to have the bucket name
> template pattern always at the start of the template. With these changes, it is
> then possible to fetch the buckets given the required permissions to do so.
>
> On the proxmox backup server side, the api endpoints to fetch the bucket list
> are implemented as well as the corresponding cli command. Finally, the bucket
> name field in the datastore edit window is replaced by an s3 bucket selector,
> which loads the accessible bucket names via the api.
>

Apart from the issue I mentioned in my other mail, this looks good to
me:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel