From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Christian Ebner" <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox{, -backup} v2 0/4] s3: extend config by provider-quirks and client options by feature list
Date: Tue, 29 Jul 2025 15:28:52 +0200 [thread overview]
Message-ID: <DBOKP8XQQTGY.38ZJSDIMDTXGS@proxmox.com> (raw)
In-Reply-To: <20250729081750.203736-1-c.ebner@proxmox.com>
On Tue Jul 29, 2025 at 10:17 AM CEST, Christian Ebner wrote:
> These patches extend the s3 client configuration by the additional
> `provider-quirks` enum, allowing to switch to provider specific implementation
> details. The provider specific quirks are then mapped to a list of features and
> limitations, added to the s3 client options.
>
> As first use-case, the `If-None-Match` header is not set during put object
> requests to Backblaze B2 or Infomaniak object stores, as these fail with an
> error with status code 501, therefore chunk uploads will fail.
>
> The patches expose the provider quirks also in an dropdown list in the advanced
> column of the s3 endpoint edit window.
>
Looks good to me:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Also quickly compiled and installed, I can at least attest that new GUI
field works as expected, however I did not test the quirks against an
actually quirky provider.
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-29 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 8:17 Christian Ebner
2025-07-29 8:17 ` [pbs-devel] [PATCH proxmox v2 1/2] s3 client: api types: extend client config by optional provider quirks Christian Ebner
2025-07-29 8:17 ` [pbs-devel] [PATCH proxmox v2 2/2] s3 client: extend client options by feature list Christian Ebner
2025-07-29 8:17 ` [pbs-devel] [PATCH proxmox-backup v2 1/2] api: s3 config: allow to update or delete endpoint quirks Christian Ebner
2025-07-29 8:17 ` [pbs-devel] [PATCH proxmox-backup v2 2/2] ui: s3 endpoint: add provider specific quirk selector Christian Ebner
2025-07-29 13:28 ` Lukas Wagner [this message]
2025-08-04 6:54 ` [pbs-devel] superseded: [PATCH proxmox{, -backup} v2 0/4] s3: extend config by provider-quirks and client options by feature list Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBOKP8XQQTGY.38ZJSDIMDTXGS@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox