From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Christian Ebner" <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 0/3] s3 client: improve error logging for invalid requests
Date: Wed, 23 Jul 2025 13:31:13 +0200 [thread overview]
Message-ID: <DBJEFWJW9V6L.3SK9EN2WI5LZC@proxmox.com> (raw)
In-Reply-To: <20250723102601.495806-1-c.ebner@proxmox.com>
On Wed Jul 23, 2025 at 12:25 PM CEST, Christian Ebner wrote:
> This patches improve error logging by refactoring the logging logic
> into a common helper and also covering responses with response status
> BAD_REQUEST. This has not been covered previously and helps to
> diagnose the reason for the bad request. In example, a malformed
> request might return the following response body:
>
> ```
> <?xml version="1.0" encoding="UTF-8"?>
> <Error>
> <Code>MalformedXML</Code>
> <Message>The XML you provided was not well formed or did not validate against our published schema.</Message>
> </Error>
> ```
>
> Christian Ebner (3):
> s3 client: fix minor whitespace issue
> s3 client: refactor error response body into dedicated helper
> s3 client: log error response body for invalid request status codes
>
> proxmox-s3-client/src/api_types.rs | 1 -
> proxmox-s3-client/src/response_reader.rs | 56 ++++++++++--------------
> 2 files changed, 23 insertions(+), 34 deletions(-)
Looks good to me:
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-23 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 10:25 Christian Ebner
2025-07-23 10:25 ` [pbs-devel] [PATCH proxmox 1/3] s3 client: fix minor whitespace issue Christian Ebner
2025-07-23 10:26 ` [pbs-devel] [PATCH proxmox 2/3] s3 client: refactor error response body into dedicated helper Christian Ebner
2025-07-23 10:26 ` [pbs-devel] [PATCH proxmox 3/3] s3 client: log error response body for invalid request status codes Christian Ebner
2025-07-23 11:31 ` Lukas Wagner [this message]
2025-07-23 11:51 ` [pbs-devel] applied: [PATCH proxmox 0/3] s3 client: improve error logging for invalid requests Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBJEFWJW9V6L.3SK9EN2WI5LZC@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox