Re: [pbs-devel] [PATCH proxmox{, -backup} v10 00/49] fix #2943: S3 storage backend for datastores

["Lukas Wagner" <l.wagner@proxmox.com>]

Did a quick test of this revision as well:

- backup
- (Live-)restore
- tested the client CLI, creating, updating and removing S3 clients
- tested "reuse existing datastore" with S3, re-importing a non-empty bucket
  from a previously deleted datastore
- tested a remote push sync job
- tested a remote pull sync job

Minor observations (these do not block a merge IMO, all material for
follow-ups):

- Maybe the "Remove Datastore" confirmation dialog should mention
  that the data in the S3 bucket is not touched (and maybe provide an option to
  also remove it? Maybe reuse the "destroy all data" flag?)

- In the "Create Datastore" dialog, both the "Reuse existing datastore"
  and "Overwrite in-use marker" checkboxes are enabled when the dialog is
  created. The second checkbox should only be enabled iff "Reuse
  existing..." is checked, which it is not by default. Likely just missing
  the "enabled: false" in the default config.

Also quickly went over the issues I raised during my review of v9 and
checked how you fixed them. Seems good to me!

Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>





_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel