public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Backup Server development discussion"
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH] notify: migrate from `log` to `tracing`
Date: Thu, 05 Dec 2024 13:02:50 +0100	[thread overview]
Message-ID: <D63R2T6163AX.3OPZK2VAXBNB@proxmox.com> (raw)
In-Reply-To: <20241205101820.208631-1-g.goller@proxmox.com>

On Thu Dec 5, 2024 at 11:18 AM CET, Gabriel Goller wrote:
> Migrated from `log` to `tracing`. Imported `tracing` only as it has a
> smaller footprint (and less dependencies) than `proxmox_log`.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-notify/Cargo.toml            |  2 +-
>  proxmox-notify/src/config.rs         |  6 ++++--
>  proxmox-notify/src/context/common.rs |  4 +++-
>  proxmox-notify/src/context/pbs.rs    |  8 +++++---
>  proxmox-notify/src/endpoints/smtp.rs |  2 +-
>  proxmox-notify/src/lib.rs            | 25 +++++++++++--------------
>  proxmox-notify/src/matcher.rs        |  5 +++--
>  proxmox-notify/src/renderer/mod.rs   |  3 ++-
>  8 files changed, 30 insertions(+), 25 deletions(-)
>

LGTM!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2024-12-05 12:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 10:18 Gabriel Goller
2024-12-05 12:02 ` Lukas Wagner [this message]
2024-12-05 12:22 ` [pbs-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D63R2T6163AX.3OPZK2VAXBNB@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal