From: "Max Carrara" <m.carrara@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets
Date: Mon, 22 Jul 2024 11:41:49 +0200 [thread overview]
Message-ID: <D2VYWR26C12Y.183XEQE0O2QT8@proxmox.com> (raw)
In-Reply-To: <27efb361-4a4f-46fd-891f-210937554f74@proxmox.com>
On Mon Jul 22, 2024 at 9:30 AM CEST, Lukas Wagner wrote:
>
>
> On 2024-07-17 17:35, Max Carrara wrote:
> >> + let handlebars = setup_handlebars();
> >> + let body_template = self.base_64_decode(self.config.body.as_deref().unwrap_or_default())?;
> >> +
> >> + let body = handlebars
> >> + .render_template(&body_template, &data)
> >> + .map_err(|err| {
> >> + // TODO: Cleanup error types, they have become a bit messy.
> >> + // No user of the notify crate distinguish between the error types any way, so
> >> + // we can refactor without any issues....
> >> + Error::Generic(format!("failed to render webhook body: {err}"))
> >
> > I'm curious, how would you clean up the error types in particular?
> >
>
> Right now, error handling is a bit messy... Some endpoints primarily use
> the `NotifyFailed` variant, which wraps another error, while in some places
> where I need a leaf error type that does not wrap any error I use the
> `Generic` variant, which only stores a string.
> I could have used the `NotifyFailed` variant here, but that one would
> not have allowed me to add additional context ("failed to render webhook ..."),
> unless wrapping another `Generic` variant...
>
> I don't have yet made any detailed plans on how to clean that up though.
Hmm, I see - thanks for elaborating! I'm not really sure how to clean
them up either, but if I can think of something, I'll let you know.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-22 9:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:27 [pbs-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets Lukas Wagner
2024-07-17 15:35 ` Max Carrara
2024-07-22 7:30 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:41 ` Max Carrara [this message]
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox v2 02/12] notify: add api for " Lukas Wagner
2024-07-17 15:35 ` [pbs-devel] [pve-devel] " Max Carrara
2024-07-22 7:32 ` Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-perl-rs v2 03/12] common: notify: add bindings for webhook API routes Lukas Wagner
2024-07-17 15:35 ` [pbs-devel] [pve-devel] " Max Carrara
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-perl-rs v2 04/12] common: notify: add bindings for get_targets Lukas Wagner
2024-07-17 15:36 ` Max Carrara
2024-07-12 11:27 ` [pbs-devel] [PATCH widget-toolkit v2 05/12] notification: add UI for adding/updating webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH manager v2 06/12] api: notifications: use get_targets impl from proxmox-notify Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH manager v2 07/12] api: add routes for webhook notification endpoints Lukas Wagner
2024-07-17 15:36 ` Max Carrara
2024-07-22 7:37 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:50 ` Max Carrara
2024-07-22 13:56 ` Thomas Lamprecht
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-backup v2 09/12] api: notification: add API routes for webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-backup v2 10/12] ui: utils: enable webhook edit window Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-mail-forward v2 12/12] bump proxmox-notify dependency Lukas Wagner
2024-07-17 15:34 ` [pbs-devel] [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Max Carrara
2024-07-22 7:50 ` Lukas Wagner
2024-07-22 12:10 ` Stefan Hanreich
2024-07-22 12:29 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2VYWR26C12Y.183XEQE0O2QT8@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox