From: "Max Carrara" <m.carrara@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-perl-rs v2 03/12] common: notify: add bindings for webhook API routes
Date: Wed, 17 Jul 2024 17:35:56 +0200 [thread overview]
Message-ID: <D2RXB5P1LDQN.2G3U0RMTVE5PJ@proxmox.com> (raw)
In-Reply-To: <20240712112755.123630-4-l.wagner@proxmox.com>
Missed a `cargo fmt` here as well ;)
On Fri Jul 12, 2024 at 1:27 PM CEST, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> common/src/notify.rs | 63 ++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/common/src/notify.rs b/common/src/notify.rs
> index e1b006b..fe192d5 100644
> --- a/common/src/notify.rs
> +++ b/common/src/notify.rs
> @@ -19,6 +19,9 @@ mod export {
> DeleteableSmtpProperty, SmtpConfig, SmtpConfigUpdater, SmtpMode, SmtpPrivateConfig,
> SmtpPrivateConfigUpdater,
> };
> + use proxmox_notify::endpoints::webhook::{
> + DeleteableWebhookProperty, WebhookConfig, WebhookConfigUpdater,
> + };
> use proxmox_notify::matcher::{
> CalendarMatcher, DeleteableMatcherProperty, FieldMatcher, MatchModeOperator, MatcherConfig,
> MatcherConfigUpdater, SeverityMatcher,
> @@ -393,6 +396,66 @@ mod export {
> api::smtp::delete_endpoint(&mut config, name)
> }
>
> + #[export(serialize_error)]
> + fn get_webhook_endpoints(
> + #[try_from_ref] this: &NotificationConfig,
> + ) -> Result<Vec<WebhookConfig>, HttpError> {
> + let config = this.config.lock().unwrap();
> + api::webhook::get_endpoints(&config)
> + }
> +
> + #[export(serialize_error)]
> + fn get_webhook_endpoint(
> + #[try_from_ref] this: &NotificationConfig,
> + id: &str,
> + ) -> Result<WebhookConfig, HttpError> {
> + let config = this.config.lock().unwrap();
> + api::webhook::get_endpoint(&config, id)
> + }
> +
> + #[export(serialize_error)]
> + #[allow(clippy::too_many_arguments)]
> + fn add_webhook_endpoint(
> + #[try_from_ref] this: &NotificationConfig,
> + endpoint_config: WebhookConfig,
> + ) -> Result<(), HttpError> {
> + let mut config = this.config.lock().unwrap();
> + api::webhook::add_endpoint(
> + &mut config,
> + endpoint_config,
> + )
> + }
> +
> + #[export(serialize_error)]
> + #[allow(clippy::too_many_arguments)]
> + fn update_webhook_endpoint(
> + #[try_from_ref] this: &NotificationConfig,
> + name: &str,
> + config_updater: WebhookConfigUpdater,
> + delete: Option<Vec<DeleteableWebhookProperty>>,
> + digest: Option<&str>,
> + ) -> Result<(), HttpError> {
> + let mut config = this.config.lock().unwrap();
> + let digest = decode_digest(digest)?;
> +
> + api::webhook::update_endpoint(
> + &mut config,
> + name,
> + config_updater,
> + delete.as_deref(),
> + digest.as_deref(),
> + )
> + }
> +
> + #[export(serialize_error)]
> + fn delete_webhook_endpoint(
> + #[try_from_ref] this: &NotificationConfig,
> + name: &str,
> + ) -> Result<(), HttpError> {
> + let mut config = this.config.lock().unwrap();
> + api::webhook::delete_endpoint(&mut config, name)
> + }
> +
> #[export(serialize_error)]
> fn get_matchers(
> #[try_from_ref] this: &NotificationConfig,
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-17 15:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:27 [pbs-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets Lukas Wagner
2024-07-17 15:35 ` Max Carrara
2024-07-22 7:30 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:41 ` Max Carrara
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox v2 02/12] notify: add api for " Lukas Wagner
2024-07-17 15:35 ` [pbs-devel] [pve-devel] " Max Carrara
2024-07-22 7:32 ` Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-perl-rs v2 03/12] common: notify: add bindings for webhook API routes Lukas Wagner
2024-07-17 15:35 ` Max Carrara [this message]
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-perl-rs v2 04/12] common: notify: add bindings for get_targets Lukas Wagner
2024-07-17 15:36 ` Max Carrara
2024-07-12 11:27 ` [pbs-devel] [PATCH widget-toolkit v2 05/12] notification: add UI for adding/updating webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH manager v2 06/12] api: notifications: use get_targets impl from proxmox-notify Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH manager v2 07/12] api: add routes for webhook notification endpoints Lukas Wagner
2024-07-17 15:36 ` Max Carrara
2024-07-22 7:37 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:50 ` Max Carrara
2024-07-22 13:56 ` Thomas Lamprecht
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-backup v2 09/12] api: notification: add API routes for webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-backup v2 10/12] ui: utils: enable webhook edit window Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] [PATCH proxmox-mail-forward v2 12/12] bump proxmox-notify dependency Lukas Wagner
2024-07-17 15:34 ` [pbs-devel] [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Max Carrara
2024-07-22 7:50 ` Lukas Wagner
2024-07-22 12:10 ` Stefan Hanreich
2024-07-22 12:29 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D2RXB5P1LDQN.2G3U0RMTVE5PJ@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox