From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Wolfgang Bumiller" <w.bumiller@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox 4/5] access: factor out user config and cache handling
Date: Tue, 11 Jun 2024 16:30:25 +0200 [thread overview]
Message-ID: <D1X9DDTRVSC8.9GEQ4CX9XUF5@proxmox.com> (raw)
In-Reply-To: <j6ha7fwqs76xfkzwpgldnbjpmlrg3knraqdhtvorffnxgtzx7h@d4b5vteetjeb>
On Tue Jun 11, 2024 at 3:07 PM CEST, Wolfgang Bumiller wrote:
> On Mon, Jun 10, 2024 at 05:42:13PM GMT, Shannon Sterz wrote:
> > this commit factors out the user config as well as the shared memory
> > based config version caching mechanism. this makes it necessary that
> > users of this crate provide the product name and a reference to a
> > shared memory location as well.
>
> Given that we have more values in the shared memory in PBS I wonder if
> we should instead provide the `get` and `increment` methods to init
> (directly as `fn` or via a trait).
yeah, that might make sense to hand that over via a trait and implement
the actually shared memory portion either in the project itself or have
a generic implementation that we can adapt to each project. not entirely
sure what the best way is, though.
if we do implement some kind of generic shared memory cache generation
counter, where would live ideal?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-11 14:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:42 [pbs-devel] [PATCH proxmox 0/5] add proxmox-access crate Shannon Sterz
2024-06-10 15:42 ` [pbs-devel] [PATCH proxmox 1/5] access: add the proxmox-access crate to reuse acl trees Shannon Sterz
2024-06-11 12:53 ` Wolfgang Bumiller
2024-06-10 15:42 ` [pbs-devel] [PATCH proxmox 2/5] access: define shared `User`, `UserWithTokens` and `ApiTokens types Shannon Sterz
2024-06-11 12:51 ` Wolfgang Bumiller
2024-06-10 15:42 ` [pbs-devel] [PATCH proxmox 3/5] access: make token shadow implementation re-usable Shannon Sterz
2024-06-10 15:42 ` [pbs-devel] [PATCH proxmox 4/5] access: factor out user config and cache handling Shannon Sterz
2024-06-11 13:07 ` Wolfgang Bumiller
2024-06-11 14:30 ` Shannon Sterz [this message]
2024-06-12 12:49 ` Wolfgang Bumiller
2024-06-10 15:42 ` [pbs-devel] [PATCH proxmox 5/5] access: increment user cache generation when saving acl config Shannon Sterz
2024-06-11 17:28 ` [pbs-devel] [PATCH proxmox 0/5] add proxmox-access crate Thomas Lamprecht
2024-06-13 12:54 ` Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1X9DDTRVSC8.9GEQ4CX9XUF5@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox