From: "Stefan Sterz" <s.sterz@proxmox.com>
To: "Stefan Sterz" <s.sterz@proxmox.com>, <pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: tape ui: unset `deleteEmpty` in `TapeBackupWindow`
Date: Thu, 25 Apr 2024 10:37:10 +0200 [thread overview]
Message-ID: <D0T2FAWKDPSX.YSZ83B6DKC62@proxmox.com> (raw)
In-Reply-To: <20240405141257.165513-1-s.sterz@proxmox.com>
On Fri Apr 5, 2024 at 4:12 PM CEST, Stefan Sterz wrote:
> since the api rejects unknown parameters, deleteEmpty needs to be
> unset here, because the endpoint for creating backups does not support
> deleting parameters. otherwise a user will get a fairly cryptic error
> message in the gui.
>
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> www/tape/window/TapeBackup.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/tape/window/TapeBackup.js b/www/tape/window/TapeBackup.js
> index 941b6b83..4c027ab0 100644
> --- a/www/tape/window/TapeBackup.js
> +++ b/www/tape/window/TapeBackup.js
> @@ -39,6 +39,7 @@ Ext.define('PBS.TapeManagement.TapeBackupWindow', {
> fieldLabel: gettext('Max Depth'),
> disabled: true,
> name: 'max-depth',
> + deleteEmpty: false,
> },
> {
> xtype: 'pbsMediaPoolSelector',
ping, this is a fairly minor improvement that fixes the one of tape
backup ui
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-04-25 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 14:12 Stefan Sterz
2024-04-25 8:37 ` Stefan Sterz [this message]
2024-04-25 9:49 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0T2FAWKDPSX.YSZ83B6DKC62@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox