From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api-types: remove influxdb name restrictions
Date: Mon, 22 Apr 2024 09:59:00 +0200 [thread overview]
Message-ID: <D0QHQGCMH2IS.18OXVAAX9LIAA@proxmox.com> (raw)
In-Reply-To: <7f1fa7cb-87ba-4f90-9763-08fa3e298285@proxmox.com>
On Mon Apr 22, 2024 at 9:26 AM CEST, Thomas Lamprecht wrote:
> Am 22/04/2024 um 09:20 schrieb Gabriel Goller:
> > On Sun Apr 21, 2024 at 1:28 PM CEST, Thomas Lamprecht wrote:
> >> for the subject please do s/name/bucket name/ as otherwise one might think
> >> this is about the ID of an InfluxDB metric server.
> >
> > Will do.
> >
> >> Am 19/04/2024 um 15:18 schrieb Gabriel Goller:
> >>> Remove the regex for influxdb organizations and buckets. Influxdb does
> >>> not place any constraints on these names and allows all characters. This
> >>> allows influxdb organization names with slashes.
> >>>
> >>> Also remove a duplicate comment and add some missing ones.
> >>
> >>
> >> did you run into this or some user (forum link, bug report)?
> >
> > From a forum thread here (will also include this in the next patch):
> > https://forum.proxmox.com/threads/influx-db-organization-doesnt-allow-slash.145402/
> >
> >> What about Proxmox VE, that also has a InfluxDB
> >
> > In Proxmox VE there are no restrictions to bucket/organization names.
> >
>
> OK, it would be nice to mention that here, because having the same schema
> and behavior across products is a merit in itself.
Thanks for the review!
Submitted a v2.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-04-22 7:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 13:18 Gabriel Goller
2024-04-21 11:28 ` Thomas Lamprecht
2024-04-22 7:20 ` Gabriel Goller
2024-04-22 7:26 ` Thomas Lamprecht
2024-04-22 7:59 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0QHQGCMH2IS.18OXVAAX9LIAA@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox