From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox v3 1/5] compression: deflate: Move encoder into a mod
Date: Fri, 12 Apr 2024 14:41:30 +0200 [thread overview]
Message-ID: <D0I5HAVDHJFX.SRCWQQFRU4PF@proxmox.com> (raw)
In-Reply-To: <20240410143036.81807-2-m.sandoval@proxmox.com>
On Wed Apr 10, 2024 at 4:30 PM CEST, Maximiliano Sandoval wrote:
> diff --git a/proxmox-compression/src/lib.rs b/proxmox-compression/src/lib.rs
> index 1fcfb977..239de623 100644
> --- a/proxmox-compression/src/lib.rs
> +++ b/proxmox-compression/src/lib.rs
> @@ -1,6 +1,6 @@
> -mod compression;
> -pub use compression::*;
> +pub use deflate::{DeflateEncoder, Level};
>
> +pub(crate) mod deflate;
Whole series looks good, so consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
The only nit is the above 'pub(crate)', which can be removed!
next prev parent reply other threads:[~2024-04-12 12:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 14:30 [pbs-devel] [PATCH proxmox v3 0/5] Teach HTTP client how to decode deflate Maximiliano Sandoval
2024-04-10 14:30 ` [pbs-devel] [PATCH proxmox v3 1/5] compression: deflate: Move encoder into a mod Maximiliano Sandoval
2024-04-12 12:41 ` Gabriel Goller [this message]
2024-04-10 14:30 ` [pbs-devel] [PATCH proxmox v3 2/5] compression: deflate: add builder pattern Maximiliano Sandoval
2024-04-10 14:30 ` [pbs-devel] [PATCH proxmox v3 3/5] compression: deflate: add a decoder Maximiliano Sandoval
2024-04-10 14:30 ` [pbs-devel] [PATCH proxmox v3 4/5] compression: deflate: add test module Maximiliano Sandoval
2024-04-10 14:30 ` [pbs-devel] [PATCH proxmox v3 5/5] http: teach the Client how to decode deflate content Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D0I5HAVDHJFX.SRCWQQFRU4PF@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox