From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3] datastore: remove datastore from internal cache based on maintenance mode
Date: Fri, 22 Mar 2024 14:52:41 +0100 [thread overview]
Message-ID: <D00BUD8VUSYR.3NBO4NQFEUXLV@proxmox.com> (raw)
In-Reply-To: <20240304132618.91099-1-h.laimer@proxmox.com>
On Mon Mar 4, 2024 at 2:26 PM CET, Hannes Laimer wrote:
> We keep a DataStore cache, so ChunkStore's and lock files are kept by
> the proxy process and don't have to be reopened every time. However, for
> specific maintenance modes, e.g. 'offline', our process should not keep
> file in that datastore open. This clears the cache entry of a datastore
> if it is in a specific maintanance mode and the last task finished, which
> also drops any files still open by the process.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
The code looks good and clippy/fmt doesn't throw any errors!
Also tested this thoroughly and it works perfectly.
Consider:
Reviewed-by: Gabriel Goller <g.goller@proxmox.com>
Tested-by: Gabriel Goller <g.goller@proxmox.com>
next prev parent reply other threads:[~2024-03-22 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 13:26 Hannes Laimer
2024-03-22 13:52 ` Gabriel Goller [this message]
2024-03-25 15:15 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D00BUD8VUSYR.3NBO4NQFEUXLV@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox