From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 8/8] gc: configure width and flex on GC Jobs columns
Date: Wed, 07 Feb 2024 10:30:44 +0100 [thread overview]
Message-ID: <CYYQPTSF2FK9.2TYMC599MJDCI@proxmox.com> (raw)
In-Reply-To: <20240206145142.1175527-10-s.lendl@proxmox.com>
On Tue Feb 6, 2024 at 3:51 PM CET, Stefan Lendl wrote:
> table expands to the full width and relevant data is still visible on a
> narrow screen.
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> www/config/GCView.js | 30 +++++++++++++++++++-----------
> 1 file changed, 19 insertions(+), 11 deletions(-)
>
> diff --git a/www/config/GCView.js b/www/config/GCView.js
> index d1f1bf71..796057ff 100644
> --- a/www/config/GCView.js
> +++ b/www/config/GCView.js
> @@ -159,63 +159,71 @@ Ext.define('PBS.config.GCJobView', {
> header: gettext('Datastore'),
> dataIndex: 'store',
> renderer: Ext.String.htmlEncode,
> - width: 120,
> sortable: true,
> hideable: false,
> + width: 150,
> + minWidth: 120,
> + maxWidth: 300,
> + flex: 2,
Indentation here (and on the other additions in the same file) looks off...
Check the internal wiki for our styleguide :)
next prev parent reply other threads:[~2024-02-07 9:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 14:51 [pbs-devel] [PATCH v2 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 3/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 4/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 5/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 6/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 7/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-06 14:51 ` [pbs-devel] [PATCH v2 proxmox-backup 8/8] gc: configure width and flex on GC Jobs columns Stefan Lendl
2024-02-07 9:30 ` Gabriel Goller [this message]
2024-02-06 14:56 ` [pbs-devel] [PATCH v2 proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-07 9:42 ` Gabriel Goller
2024-02-08 14:01 ` Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYYQPTSF2FK9.2TYMC599MJDCI@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox