From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/8] prune: use NoneText as emptyValue in PruneJobEdit
Date: Mon, 05 Feb 2024 14:50:36 +0100 [thread overview]
Message-ID: <CYX6ZPOQU2XA.7DORR7BYGXAV@proxmox.com> (raw)
In-Reply-To: <20240205115830.523721-5-s.lendl@proxmox.com>
On Mon Feb 5, 2024 at 12:58 PM CET, Stefan Lendl wrote:
> Display None value as presented in Proxmox.Utils.NoneText.
> Make this identical to other uses where a None value is displayed
>
> Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
> ---
> www/window/PruneJobEdit.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
> index 84159a9d..fa4fc149 100644
> --- a/www/window/PruneJobEdit.js
> +++ b/www/window/PruneJobEdit.js
> @@ -114,7 +114,7 @@ Ext.define('PBS.window.PruneJobEdit', {
> fieldLabel: gettext('Prune Schedule'),
> xtype: 'pbsCalendarEvent',
> name: 'schedule',
> - emptyText: gettext('none (disabled)'),
> + emptyText: gettext(Proxmox.Utils.NoneText + " (disabled)"),
> cbind: {
> deleteEmpty: '{!isCreate}',
> value: '{scheduleValue}',
Hmm, the schedule value here is not optional, so adding `(disabled)` is
kind of misleading... I think it's better to remove `emptyText` and add
a `allowBlank: false` here.
next prev parent reply other threads:[~2024-02-05 13:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:58 [pbs-devel] [PATCH proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-02-05 13:58 ` Gabriel Goller
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 3/8] prune: use NoneText as emptyValue in PruneJobEdit Stefan Lendl
2024-02-05 13:50 ` Gabriel Goller [this message]
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 4/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 5/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 6/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 7/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 8/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-05 13:33 ` [pbs-devel] [PATCH proxmox-backup 0/8] Add GC job status to datastore and global prune job view Gabriel Goller
2024-02-06 14:54 ` Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYX6ZPOQU2XA.7DORR7BYGXAV@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox