From: "Gabriel Goller" <g.goller@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/8] Add GC job status to datastore and global prune job view.
Date: Mon, 05 Feb 2024 14:33:25 +0100 [thread overview]
Message-ID: <CYX6MJUN29NT.294W9R1J5UC2K@proxmox.com> (raw)
In-Reply-To: <20240205115830.523721-2-s.lendl@proxmox.com>
Thanks for picking this up!
Did some quick testing and it seems to work nicely—just some small
ui quirks that need to be ironed out:
The "Garbage Collection Jobs" table never takes the whole width
like the "Prune Jobs" view, I think you'll need to adjust the width,
max-width and min-width values a bit!
Also eslint spits out some warnings:
```
[./config/GCView.js]:
WARN: line 39 col 41: semi - Missing semicolon. (*)
WARN: line 47 col 16: comma-dangle - Missing trailing comma. (*)
WARN: line 48 col 8: comma-dangle - Missing trailing comma. (*)
```
Otherwise LGTM!
next prev parent reply other threads:[~2024-02-05 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:58 Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 1/8] api: garbage collect job status Stefan Lendl
2024-02-05 13:58 ` Gabriel Goller
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 2/8] gc: global prune and gc job view Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 3/8] prune: use NoneText as emptyValue in PruneJobEdit Stefan Lendl
2024-02-05 13:50 ` Gabriel Goller
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 4/8] gc: move datastore/PruneAndGC to config/PruneAndGC Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 5/8] gc: hide datastore column in local gc view Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 6/8] ui: order Prune&GC before SyncJobs Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 7/8] cli: list gc jobs with proxmox-backup-manager Stefan Lendl
2024-02-05 11:58 ` [pbs-devel] [PATCH proxmox-backup 8/8] gc: show removed and pending chunks of last run in ui Stefan Lendl
2024-02-05 13:33 ` Gabriel Goller [this message]
2024-02-06 14:54 ` [pbs-devel] [PATCH proxmox-backup 0/8] Add GC job status to datastore and global prune job view Stefan Lendl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CYX6MJUN29NT.294W9R1J5UC2K@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox