Re: [pbs-devel] [PATCH proxmox-backup v3 0/6] local sync-jobs

["Lukas Wagner" <l.wagner@proxmox.com>]

On Tue Aug 8, 2023 at 2:13 PM CEST, Hannes Laimer wrote:
> Add support for local sync. SyncJobs without a remote are considered local, and
> use a different logic for pulling. In the course of adding the extra pull logic,
> the pull code was rewritten to basically be source independent. Also cli
> completion and the UI was updated to allow Remotes in SyncJobs to be optional.
>

Gave these patches a quick test on the latest master, here is what I found:
  - Rate limiting does not seem to be implemented for local sync jobs. 
    Would be a nice addition in the future (e.g. to reduce IO load during sync
    jobs). For the time being, it would be good to structure the sync job UI
    in such a way that it is clear that a rate limit has no effect on local
    sync jobs.
  - It seems to be possible to create a local sync job that syncs a store to
    itself (same namespace). The job will ultimately fail since we read/write
    from the same (locked) snapshot. I guess it would be good to catch this
    earlier on and provide a better error in that case. Also, maybe there
    should be checks in place when creating the sync job. Might be tricky to
    figure out which variants to allow, since syncing a namespace to another
    namespace within the same store might make sense in *some* use cases.

Apart from that, everything seems to work as expected, consider this:

Tested-by: Lukas Wagner <l.wagner@proxmox.com>