public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: i@leaskh.com
To: pbs-devel@lists.proxmox.com
Subject: [PATCH widget-toolkit 2/2] fix #8227: ui: offer encapsulated bond transmit hash policies
Date: Sun, 25 Oct 2026 14:58:29 -0500	[thread overview]
Message-ID: <CAHNRs8PUKi_eL4kHdYmD23uC3YicQJGAsE-c4Os-j7C3vT=unw@mail.gmail.com> (raw)
In-Reply-To: <CAHNRs8O4SVDfmybXUpTbLJX9fG7s13s27bhu7dj5XiSh=3qx2Q@mail.gmail.com>

From: Leask Wong <i@leaskh.com>

Add encap2+3 and encap3+4 to the shared policy selector, matching
the accompanying proxmox-network-api extension. Keep the existing
policy values, labels and default ordering.

JavaScript syntax and a runtime selector-definition check pass.

Signed-off-by: Leask Wong <i@leaskh.com>
---
 src/form/BondModeSelector.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/form/BondModeSelector.js b/src/form/BondModeSelector.js
index cb87f81..2c24bbd 100644
--- a/src/form/BondModeSelector.js
+++ b/src/form/BondModeSelector.js
@@ -37,5 +37,7 @@ Ext.define('Proxmox.form.BondPolicySelector', {
         ['layer2', 'layer2'],
         ['layer2+3', 'layer2+3'],
         ['layer3+4', 'layer3+4'],
+        ['encap2+3', 'encap2+3'],
+        ['encap3+4', 'encap3+4'],
     ],
 });
-- 
2.56.0



On Sun, 25 Oct 2026 14:57:50 -0500, i@leaskh.com wrote:
> Hi,
>
> This series fixes PBS bug #8227:
> https://bugzilla.proxmox.com/show_bug.cgi?id=8227
>
> An operational Linux 802.3ad bond using encap3+4 makes PBS reject
> /etc/network/interfaces and prevents the Network Interfaces list from
> loading. Linux and ifupdown2 support the policy; the shared Rust API's
> enum and the shared UI selector currently list only the three layer*
> policies.
>
> Patch 1/2 targets proxmox.git and adds encap2+3 and encap3+4 to the enum,
> generated schema and Display implementation. It includes validation and
> configuration round-trip regression tests. Existing values and invalid
> name validation are preserved.
>
> Patch 2/2 targets proxmox-widget-toolkit.git and exposes the two policies
> in the shared selector. It is the companion UI change to patch 1/2.
>
> Validation:
> - Native Linux x86_64: all 30 network API library tests pass with the
>   impl feature. Against the old enum, the two new acceptance/round-trip
>   tests fail with the expected policy rejection.
> - Round trips cover five policies, both 802.3ad/balance-xor modes and
>   both keyword spellings, including an unrelated following bridge.
> - JavaScript syntax and selector-definition runtime checks pass.
> - Rust formatting, whitespace and patch application checks pass.
>
> The Linux build used a disposable workspace restricted to ten local
> crates, including the network API, omitting non-target dev resolution.
> The build setup did not alter library sources. Dependencies came from
> crates.io and OpenSSL headers were unpacked privately. This is not a
> full Debian package build or an end-to-end GUI test, and no running
> host's network configuration was changed.
>
> I emailed my Individual CLA privately to office@proxmox.com today,
> identifying Leask Wong <i@leaskh.com> as my Git author identity.
> CLA registration has not yet been verified.
>
> The existing Bugzilla attachments contain the same code changes:
> https://bugzilla.proxmox.com/attachment.cgi?id=2193
> https://bugzilla.proxmox.com/attachment.cgi?id=2194
> These mail patches additionally include the requested sign-off trailer.
>
> Please review, and let me know if any changes are needed.
>
> Thanks,
> Leask



      parent reply	other threads:[~2026-10-27  9:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 19:57 [PATCH proxmox,widget-toolkit 0/2] fix #8227: support encapsulated bond hash policies i
2026-10-25 19:58 ` [PATCH proxmox 1/2] fix #8227: network api: " i
2026-10-25 19:58 ` i [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHNRs8PUKi_eL4kHdYmD23uC3YicQJGAsE-c4Os-j7C3vT=unw@mail.gmail.com' \
    --to=i@leaskh.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal