From: Christian Ebner <c.ebner@proxmox.com>
To: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>,
"Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] client: catalog: improve error message for missing catalog
Date: Tue, 16 Jul 2024 11:04:29 +0200 [thread overview]
Message-ID: <9e58459a-be75-4209-8daf-dba83d6aab68@proxmox.com> (raw)
In-Reply-To: <1046998832.230.1721120472062@webmail.proxmox.com>
On 7/16/24 11:01, Fabian Grünbichler wrote:
>
>> Christian Ebner <c.ebner@proxmox.com> hat am 16.07.2024 10:54 CEST geschrieben:
>>
>>
>> On 7/16/24 10:49, Fabian Grünbichler wrote:
>>>
>>>> Christian Ebner <c.ebner@proxmox.com> hat am 15.07.2024 15:46 CEST geschrieben:
>>>>
>>>>
>>>> Commit c0302805c "client: backup: conditionally write catalog for
>>>> file level backups" drops encoding of the dedicated catalog when
>>>> archives are encoded as split metadata/data archives with the
>>>> `change-detection-mode` set to `data` or `metadata`.
>>>>
>>>> Since the catalog is not present anymore, accessing these snapshots
>>>> via the `proxmox-backup-client catalog` command is obsolete for these
>>>> cases, one should opt for the `proxmox-backup-client mount` command
>>>> to inspect these archives instead.
>>>>
>>>> Improve the error message one gets when trying to access such
>>>> snapshots by checking if the catalog is present in the manifest and if
>>>> not, check if it contains a split pxar archive.
>>>>
>>>> A caller now gets the following error message:
>>>>
>>>> ```
>>>> no catalog for split pxar archives, use `mount` instead to inspect content
>>>> ```
>>>>
>>>> instead of the rather generic
>>>>
>>>> ```
>>>> Unable to open dynamic index "/<snapshot-path>/catalog.pcat1.didx"
>>>> - No such file or directory (os error 2)
>>>> ```
>>>
>>> alternatively, couldn't we adapt the CLI call like we did the API endpoint, and print a file listing using the metadata archive? mounting and then calling find seems a bit roundabout, if we can easily offer the information directly?
>>>
>>
>> Yes, for the catalog dump this would indeed be similar to the API
>> endpoint. I however did not want to go that route, because then one
>> should offer the catalog shell as well I guess?
>
> that should be do-able as well I guess (although the advantage is a bit less clear there, other than muscle-memory/convenience ;))
Okay, than I will have a go at implementing this!
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-07-16 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 13:46 Christian Ebner
2024-07-16 8:49 ` Fabian Grünbichler
2024-07-16 8:54 ` Christian Ebner
2024-07-16 9:01 ` Fabian Grünbichler
2024-07-16 9:04 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e58459a-be75-4209-8daf-dba83d6aab68@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox