From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] ui: tape/ChangerStatus: improve layout for large libraries
Date: Mon, 26 Jul 2021 10:12:34 +0200 [thread overview]
Message-ID: <9d8271c0-e3c7-c935-39a5-58980eb83942@proxmox.com> (raw)
In-Reply-To: <20210723063151.292363-1-d.csapak@proxmox.com>
applied
On 7/23/21 8:31 AM, Dominik Csapak wrote:
> instead of having the grid be as tall as possible and the containing
> panel scroll. limit the grids height to the panel size and scroll the
> grid.
>
> this has two advantages:
> * if a user has many slots, it is now possible to to navigate the other
> grids to the position wanted
> * having the grids scroll, means it can use extjs' buffered renderer,
> which makes the view much more responsive (in case of hundreds of
> slots)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/tape/ChangerStatus.js | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
> index 97b8f78e..a99b6ba6 100644
> --- a/www/tape/ChangerStatus.js
> +++ b/www/tape/ChangerStatus.js
> @@ -693,9 +693,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> },
> ],
>
> - layout: 'auto',
> + layout: 'fit',
> bodyPadding: 5,
> - scrollable: true,
>
> items: [
> {
> @@ -703,7 +702,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> reference: 'content',
> layout: {
> type: 'hbox',
> - aling: 'stretch',
> + align: 'stretch',
> },
> items: [
> {
> @@ -711,6 +710,7 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> reference: 'slots',
> title: gettext('Slots'),
> padding: 5,
> + srollable: true,
> flex: 1,
> store: {
> type: 'diff',
> @@ -771,10 +771,16 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> defaults: {
> padding: 5,
> },
> + layout: {
> + type: 'vbox',
> + align: 'stretch',
> + },
> items: [
> {
> xtype: 'grid',
> reference: 'drives',
> + scrollable: true,
> + maxHeight: 350, // ~10 drives
> title: gettext('Drives'),
> store: {
> type: 'diff',
> @@ -918,6 +924,8 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
> {
> xtype: 'grid',
> reference: 'import_export',
> + flex: 1,
> + srollable: true,
> store: {
> type: 'diff',
> rstore: {
prev parent reply other threads:[~2021-07-26 8:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 6:31 [pbs-devel] " Dominik Csapak
2021-07-26 8:12 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d8271c0-e3c7-c935-39a5-58980eb83942@proxmox.com \
--to=dietmar@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox