From: Christian Ebner <c.ebner@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 6/7] ui: add run-on-mount checkbox to SyncJob form
Date: Fri, 4 Jul 2025 13:34:50 +0200 [thread overview]
Message-ID: <9cbe19d3-1bfb-41f8-a94d-4f8f110607b5@proxmox.com> (raw)
In-Reply-To: <20250604123054.87007-7-h.laimer@proxmox.com>
On 6/4/25 14:30, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> www/window/SyncJobEdit.js | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 4cef9a1d..73a489f1 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -195,7 +195,7 @@ Ext.define('PBS.window.SyncJobEdit', {
> xtype: 'pbsCalendarEvent',
> name: 'schedule',
> fieldLabel: gettext('Sync Schedule'),
> - emptyText: gettext('none (disabled)'),
> + emptyText: gettext('none'),
> cbind: {
> deleteEmpty: '{!isCreate}',
> value: '{scheduleValue}',
> @@ -451,6 +451,17 @@ Ext.define('PBS.window.SyncJobEdit', {
> uncheckedValue: false,
> value: false,
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'run-on-mount',
> + fieldLabel: gettext('Run when mounted'),
> + autoEl: {
> + tag: 'div',
> + 'data-qtip': gettext('Run this job when a relevant removable datastore is mounted.'),
> + },
> + uncheckedValue: false,
> + value: false,
> + },
> ],
> },
> {
nit: pre-existing for other boolean flags here as well, but this should
make sure that it is set as `delete` value if set to it's default.
Otherwise this is not removed from the sync job config, but set to the
default instead. Removing it will help reduce the size of the config and
improve it's readability.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-04 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 12:30 [pbs-devel] [PATCH-SERIES proxmox/proxmox-backup v3 0/7] trigger sync jobs on mount Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox v3 1/7] pbs-api-types: add run-on-mount flag to SyncJobConfig Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 2/7] api: config: sync: update run-on-mount correctly Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 3/7] api: admin: run configured sync jobs when a datastore is mounted Hannes Laimer
2025-07-04 11:30 ` Christian Ebner
2025-07-16 12:14 ` Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 4/7] api: admin: trigger sync jobs only on datastore mount Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 5/7] bin: manager: run uuid_mount/mount tasks on the proxy Hannes Laimer
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 6/7] ui: add run-on-mount checkbox to SyncJob form Hannes Laimer
2025-07-04 11:34 ` Christian Ebner [this message]
2025-06-04 12:30 ` [pbs-devel] [PATCH proxmox-backup v3 7/7] ui: add task title for triggering sync jobs Hannes Laimer
2025-07-04 12:42 ` Christian Ebner
2025-07-04 11:41 ` [pbs-devel] [PATCH-SERIES proxmox/proxmox-backup v3 0/7] trigger sync jobs on mount Christian Ebner
2025-07-16 14:54 ` [pbs-devel] superseded: " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cbe19d3-1bfb-41f8-a94d-4f8f110607b5@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal