From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] close #3777: api: Add source information to backup logs
Date: Wed, 13 Sep 2023 10:12:39 +0200 [thread overview]
Message-ID: <9c21f47c-551e-9e1b-fea6-ab2a215b357b@proxmox.com> (raw)
In-Reply-To: <30ac83ba-bd66-423a-8d7d-d4aab4134035@proxmox.com>
On 9/13/23 09:08, Thomas Lamprecht wrote:
> Am 08/09/2023 um 16:01 schrieb Gabriel Goller:
>> On 9/7/23 18:53, Thomas Lamprecht wrote:
>>> Oh, and for quite a few users the IPv4 mapped as IPv6 notation looks odd, so dropping the
>>> ::ffff: prefix might be worth it, but no hard feelings, we can always change that if there
>>> are complaints..
>> Noticed that too, but IMO staying 'correct' is more important than making the output pretty.
> How is a IPv4 mapped as IPv6 more correct than a IPv4, it's literally the same thing
> in two different notations?
You're right, they are the same thing, but I wanted to maintain
consistency with
how we currently get the ip address and don't make any unnecessary string
operations.
But, as I said, if you feel like this should be stripped, I'll go ahead
and change it.
prev parent reply other threads:[~2023-09-13 8:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 7:40 Gabriel Goller
2023-09-07 16:53 ` Thomas Lamprecht
2023-09-08 14:01 ` Gabriel Goller
2023-09-13 7:08 ` Thomas Lamprecht
2023-09-13 8:12 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c21f47c-551e-9e1b-fea6-ab2a215b357b@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox