public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/5] ui: tape/ChangerStatus: add inventory button
Date: Fri, 5 Feb 2021 15:27:58 +0100	[thread overview]
Message-ID: <9bf76ae8-e53f-c2b4-e6c9-e8d5ca34cfe0@proxmox.com> (raw)
In-Reply-To: <20210205142620.380-3-d.csapak@proxmox.com>

On 2/5/21 15:26, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   www/tape/ChangerStatus.js | 39 +++++++++++++++++++++++++++++++++++++++
>   1 file changed, 39 insertions(+)
> 
> diff --git a/www/tape/ChangerStatus.js b/www/tape/ChangerStatus.js
> index abe652b9..c80c63cd 100644
> --- a/www/tape/ChangerStatus.js
> +++ b/www/tape/ChangerStatus.js
> @@ -341,6 +341,36 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
>   	    }).show();
>   	},
>   
> +	inventory: function() {
> +	    let me = this;
> +	    let vm = me.getViewModel();
> +	    let changer = vm.get('changer');
> +	    if (changer === '') {
> +		return;
> +	    }
> +
> +	    Ext.create('Proxmox.window.Edit', {
> +		title: gettext('Barcode Label'),

that should ofc be 'Inventory' instead ...
i can send a v2 or a fixup...

> +		showTaskViewer: true,
> +		method: 'PUT',
> +		url: '/api2/extjs/tape/drive',
> +		submitUrl: function(url, values) {
> +		    let drive = values.drive;
> +		    delete values.drive;
> +		    return `${url}/${encodeURIComponent(drive)}/inventory`;
> +		},
> +
> +		items: [
> +		    {
> +			xtype: 'pbsDriveSelector',
> +			fieldLabel: gettext('Drive'),
> +			name: 'drive',
> +			changer: changer,
> +		    },
> +		],
> +	    }).show();
> +	},
> +
>   	reload: async function() {
>   	    let me = this;
>   	    let view = me.getView();
> @@ -440,6 +470,15 @@ Ext.define('PBS.TapeManagement.ChangerStatus', {
>   		disabled: '{!changerSelected}',
>   	    },
>   	},
> +	{
> +	    text: gettext('Inventory'),
> +	    xtype: 'proxmoxButton',
> +	    handler: 'inventory',
> +	    iconCls: 'fa fa-book',
> +	    bind: {
> +		disabled: '{!changerSelected}',
> +	    },
> +	},
>       ],
>   
>       layout: 'auto',
> 





  reply	other threads:[~2021-02-05 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 14:26 [pbs-devel] [PATCH proxmox-backup 1/5] tape/inventory: fix missing parameter in error message Dominik Csapak
2021-02-05 14:26 ` [pbs-devel] [PATCH proxmox-backup 2/5] ui: tape/ChangerStatus: remove unnecessary buttons Dominik Csapak
2021-02-05 14:26 ` [pbs-devel] [PATCH proxmox-backup 3/5] ui: tape/ChangerStatus: add inventory button Dominik Csapak
2021-02-05 14:27   ` Dominik Csapak [this message]
2021-02-05 14:26 ` [pbs-devel] [PATCH proxmox-backup 4/5] ui: tape/DriveConfig: add Catalog button Dominik Csapak
2021-02-05 14:26 ` [pbs-devel] [PATCH proxmox-backup 5/5] ui: tape/DriveConfig: add missing tooltips Dominik Csapak
2021-02-05 15:13 ` [pbs-devel] applied: [PATCH proxmox-backup 1/5] tape/inventory: fix missing parameter in error message Dietmar Maurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bf76ae8-e53f-c2b4-e6c9-e8d5ca34cfe0@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal