From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: fix read element status for some changers
Date: Tue, 3 Sep 2024 08:55:40 +0200 [thread overview]
Message-ID: <9be18be1-f600-4292-bef7-559a2946a994@proxmox.com> (raw)
In-Reply-To: <1329219679.22023.1725341175476@webmail.proxmox.com>
On 9/3/24 07:26, Dietmar Maurer wrote:
>> It seems some changers are setting the PVolTag/AVolTag flags in the
>> ELEMENT STATUS page response, but don't include the actual fields then.
>> To make it work with such changers, downgrade the errors to warnings, so
>> we can continue to decode the remaining data.
>
> cant we simply check if there is remaining data in the reader?
yes we could, but we have to do it outside the functions, because
we don't have access to the reader there, only to something that
implements `read`
should i send a patch that checks the remaining size beforehand?
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-09-03 6:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 14:04 Dominik Csapak
2024-09-03 5:26 ` Dietmar Maurer
2024-09-03 6:55 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be18be1-f600-4292-bef7-559a2946a994@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox