public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] ui: user edit: don't send realm property
@ 2024-03-06 11:45 Stefan Sterz
  2024-03-07  9:42 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Sterz @ 2024-03-06 11:45 UTC (permalink / raw)
  To: pbs-devel

the api does not accept a realm property here, it is only needed to
construct a proper user id of the form `{username}@{realm}`. so
remove it before sending it to the api and getting an error in return.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
 www/window/UserEdit.js | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/www/window/UserEdit.js b/www/window/UserEdit.js
index 9a48b32f..165597bb 100644
--- a/www/window/UserEdit.js
+++ b/www/window/UserEdit.js
@@ -199,6 +199,10 @@ Ext.define('PBS.window.UserEdit', {
 	    delete values.password;
 	}
 
+	if (values.realm) {
+	    delete values.realm;
+	}
+
 	return values;
     },
 
-- 
2.39.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] ui: user edit: don't send realm property
  2024-03-06 11:45 [pbs-devel] [PATCH proxmox-backup] ui: user edit: don't send realm property Stefan Sterz
@ 2024-03-07  9:42 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-03-07  9:42 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Stefan Sterz

Am 06/03/2024 um 12:45 schrieb Stefan Sterz:
> the api does not accept a realm property here, it is only needed to
> construct a proper user id of the form `{username}@{realm}`. so
> remove it before sending it to the api and getting an error in return.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
>  www/window/UserEdit.js | 4 ++++
>  1 file changed, 4 insertions(+)
> 
>

applied with some general clean-up of that function on top (it e.g. deleted
values.username that just never exists), thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-07  9:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 11:45 [pbs-devel] [PATCH proxmox-backup] ui: user edit: don't send realm property Stefan Sterz
2024-03-07  9:42 ` [pbs-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal