From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v7] fix #3854 paperkey import to proxmox-tape
Date: Wed, 6 Apr 2022 16:35:25 +0200 [thread overview]
Message-ID: <99daec45-2218-1b05-ee75-bc0ce01ceabe@proxmox.com> (raw)
In-Reply-To: <20220324114930.99788-1-m.frank@proxmox.com>
On 24.03.22 12:49, Markus Frank wrote:
> added a parameter to the cli for importing tape key via a json-parameter or
> via reading a exported paperkey-file or json-file.
> For this i also added a backupkey parameter to the api, but here it only
> accepts json.
>
> The cli interprets the parameter first as json-string, then json-file
> and last as paperkey-file.
>
> functionality:
> proxmox-tape key paperkey [fingerprint of existing key] > paperkey.backup
> proxmox-tape key restore --backupkey paperkey.backup # key from line above
> proxmox-tape key restore --backupkey paperkey.json # only the json
> proxmox-tape key restore --backupkey '{"kdf": {"Scrypt": ...' # json as string
>
> for importing the key as paperkey-file it is irrelevant, if the paperkey got exported as html
> or txt.
>
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> src/api2/tape/drive.rs | 65 +++++++++++++++++++-------
> src/bin/proxmox_tape/encryption_key.rs | 59 +++++++++++++++++++++--
> 2 files changed, 102 insertions(+), 22 deletions(-)
>
>
applied, thanks! While this was OK code-wise I made a not so small followup commit
for some semantic changes, mostly it was for splitting CLI behavior for key-string
vs. key-file again. Would appreciate if you also re-take a look to ensure I did
not botched something in progress.
next prev parent reply other threads:[~2022-04-06 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 11:49 [pbs-devel] " Markus Frank
2022-04-06 14:35 ` Thomas Lamprecht [this message]
2022-04-07 9:42 ` [pbs-devel] applied: " Markus Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99daec45-2218-1b05-ee75-bc0ce01ceabe@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.frank@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox