From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 00/14] various clippy fixes
Date: Mon, 19 Apr 2021 08:59:36 +0200 [thread overview]
Message-ID: <992ab3e5-3159-d09a-a3fc-e017da96c320@proxmox.com> (raw)
In-Reply-To: <1524469767.3672.1618755986380@webmail.proxmox.com>
On 4/18/21 16:26, Dietmar Maurer wrote:
> Some of those changes may make sense, but it is really
> a PITA to review them. Every change can break the code an introduce new
> errors (which already happened in the past).
>
any examples for those errors? (just for my curiosity)
can i do anything to make reviewing easier?
> On the other side, It is hard to see any advantages for
> most of those changes.
>
IMHO, most changes do make the code better and/or more
readable (e.g. nested ifs, complex types, safety annotation,
absurd extreme comparisons), any specific ones you
dislike?
if there are some classes of warnings/errors that do not
make sense, it would probably be good if we introduce some
custom clippy configs in our repos
next prev parent reply other threads:[~2021-04-19 6:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 14:26 Dietmar Maurer
2021-04-19 6:59 ` Dominik Csapak [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-16 10:28 Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=992ab3e5-3159-d09a-a3fc-e017da96c320@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox