From: Max Carrara <m.carrara@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection
Date: Tue, 27 Jun 2023 11:39:01 +0200 [thread overview]
Message-ID: <97ea7baf-fb8b-0ad5-4881-a2e248a4922c@proxmox.com> (raw)
In-Reply-To: <c32e86cd-d1ea-ca21-eb06-bbea7ea52b1e@proxmox.com>
On 6/23/23 12:55, Thomas Lamprecht wrote:
> Am 23/06/2023 um 12:15 schrieb Max Carrara:
>> On 6/22/23 11:15, Max Carrara wrote:
>>> This patch series adds support for redirecting HTTP requests to HTTPS. This is
>>> done by peeking into the incoming TCP stream's buffer in order to check whether
>>> the client initiates a TLS handshake or not.
>>>
>>> Secure and insecure connections are then sent along separate channels, allowing
>>> them to be handled by different `hyper::Server`s (if so desired).
>>>
>>> Finally, `proxmox-backup-proxy` is adapted correspondingly, making it a little
>>> more convenient to access PBS via its web interface.
>>>
>>> proxmox:
>>>
>>> Max Carrara (2):
>>> rest-server: Add `BiAcceptBuilder`
>>> rest-server: Add `Redirector`
>>>
>>> proxmox-rest-server/src/connection.rs | 327 ++++++++++++++++++++++++++
>>> proxmox-rest-server/src/lib.rs | 2 +-
>>> proxmox-rest-server/src/rest.rs | 76 ++++++
>>> 3 files changed, 404 insertions(+), 1 deletion(-)
>>>
>>>
>>> proxmox-backup:
>>>
>>> Max Carrara (1):
>>> proxy: redirect HTTP requests to HTTPS
>>>
>>> src/bin/proxmox-backup-proxy.rs | 45 ++++++++++++++++++++++++++++-----
>>> 1 file changed, 38 insertions(+), 7 deletions(-)
>>>
>>
>> Note: This series was built and tested on the `stable-2` branches of
>> either repo, but applies on both `master` branches as well.
>>
>
> Ok but I'd rather only apply this to master. This isn't a clear targeted bug fix,
> so rather would keep away any potential regression from the stable branch.
>
FYI: just built and tested it on master; works as as of commit
54cb9be8edba5e78071275df892516742fa26a75
Just wanted to make sure myself, even though Lukas already tested it
(thanks!)
next prev parent reply other threads:[~2023-06-27 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 9:15 Max Carrara
2023-06-22 9:15 ` [pbs-devel] [PATCH proxmox 1/3] rest-server: Add `BiAcceptBuilder` Max Carrara
2023-07-14 9:20 ` Wolfgang Bumiller
2023-07-18 5:46 ` Max Carrara
2023-06-22 9:15 ` [pbs-devel] [PATCH proxmox 2/3] rest-server: Add `Redirector` Max Carrara
2023-07-14 9:24 ` Wolfgang Bumiller
2023-07-18 5:59 ` Max Carrara
2023-06-22 9:15 ` [pbs-devel] [PATCH proxmox-backup 3/3] proxy: redirect HTTP requests to HTTPS Max Carrara
2023-06-23 10:15 ` [pbs-devel] [PATCH proxmox, proxmox-backup 0/3] Add support for HTTP to HTTPS redirection Max Carrara
2023-06-23 10:55 ` Thomas Lamprecht
2023-06-27 9:39 ` Max Carrara [this message]
2023-06-23 11:40 ` Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97ea7baf-fb8b-0ad5-4881-a2e248a4922c@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox