public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/6] add compression to api/static files
Date: Wed, 31 Mar 2021 12:52:14 +0200	[thread overview]
Message-ID: <97b40547-a5ad-25f9-7150-7a93c28f0f73@proxmox.com> (raw)
In-Reply-To: <20210331094418.16609-1-d.csapak@proxmox.com>

On 31.03.21 11:44, Dominik Csapak wrote:
> by using the flate2 crate
> 
> this series will also help send a simpler version of my zip deflate
> encoder patch (i'll send that in the next few days)

high level comment: talked with Dietmar in the morning, and we agreed to
avoid a disk cache for now, the static files are seldom served so probably
not worth a more complex caching system which produces disk IO - we can
always add it in the future, if the on-demand approach shows problems.

> 
> Dominik Csapak (6):
>   tools: add compression module
>   tools/compression: add DeflateEncoder and helpers
>   add a CACHE_DIR to the created directories on daemon startup
>   server/rest: add helpers for compression
>   server/rest: compress api calls
>   server/rest: compress static files
> 
>  Cargo.toml                    |   1 +
>  src/bin/proxmox-backup-api.rs |   2 +-
>  src/buildcfg.rs               |   6 +
>  src/server/rest.rs            | 181 ++++++++++++++++++++----
>  src/server/worker_task.rs     |   9 +-
>  src/tools.rs                  |   1 +
>  src/tools/compression.rs      | 251 ++++++++++++++++++++++++++++++++++
>  tests/worker-task-abort.rs    |   2 +-
>  8 files changed, 424 insertions(+), 29 deletions(-)
>  create mode 100644 src/tools/compression.rs
> 





      parent reply	other threads:[~2021-03-31 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31  9:44 Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 1/6] tools: add compression module Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 2/6] tools/compression: add DeflateEncoder and helpers Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 3/6] add a CACHE_DIR to the created directories on daemon startup Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 4/6] server/rest: add helpers for compression Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 5/6] server/rest: compress api calls Dominik Csapak
2021-03-31  9:44 ` [pbs-devel] [PATCH proxmox-backup 6/6] server/rest: compress static files Dominik Csapak
2021-03-31 10:52 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97b40547-a5ad-25f9-7150-7a93c28f0f73@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal