From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v6 0/6] local sync-jobs
Date: Sat, 25 Nov 2023 17:14:03 +0100 [thread overview]
Message-ID: <97978cef-5b48-49c5-ab97-94154045b9dd@proxmox.com> (raw)
In-Reply-To: <20231121143155.370916-1-h.laimer@proxmox.com>
Am 21/11/2023 um 15:31 schrieb Hannes Laimer:
> Add support for local sync. SyncJobs without a remote are considered local, and
> use a different logic for pulling. In the course of adding the extra pull logic,
> the pull code was rewritten to basically be source independent. Also cli
> completion and the UI was updated to allow Remotes in SyncJobs to be optional.
> Hannes Laimer (6):
> accept a ref to a HttpClient
> pull: refactor pulling from a datastore
> pull: add support for pulling from local datastore
> manager: add completion for opt. Remote in SyncJob
> api: make Remote for SyncJob optional
> ui: add support for optional Remote in SyncJob
>
> Cargo.toml | 2 +
> examples/download-speed.rs | 2 +-
> pbs-api-types/src/jobs.rs | 9 +-
> pbs-client/src/backup_reader.rs | 2 +-
> pbs-datastore/src/read_chunk.rs | 2 +-
> proxmox-backup-client/src/catalog.rs | 4 +-
> proxmox-backup-client/src/main.rs | 2 +-
> proxmox-backup-client/src/mount.rs | 2 +-
> proxmox-file-restore/src/main.rs | 4 +-
> src/api2/config/remote.rs | 16 +-
> src/api2/config/sync.rs | 41 +-
> src/api2/node/tasks.rs | 3 +-
> src/api2/pull.rs | 60 +-
> src/bin/proxmox-backup-manager.rs | 67 +-
> src/bin/proxmox_backup_debug/diff.rs | 2 +-
> src/server/email_notifications.rs | 18 +-
> src/server/pull.rs | 1073 ++++++++++++++++----------
> www/Utils.js | 5 +
> www/config/SyncView.js | 1 +
> www/form/RemoteTargetSelector.js | 36 +-
> www/window/SyncJobEdit.js | 73 +-
> 21 files changed, 934 insertions(+), 490 deletions(-)
>
applied series, thanks!
Can you please sent a follow-up for Gabriel comment:
Am 22/11/2023 um 11:14 schrieb Gabriel Goller:
> You are allowed to create a local sync to the same datastore when using
> `proxmox-backup-manager` in the cli. You will not be able to run that sync
> job (neither the ui, nor the cli), but it would still be nice if there was
> some client-side error prohibiting you from creating the job.
As I also think that this is not fully ideal and should be blocked to happen
for better UX.
prev parent reply other threads:[~2023-11-25 16:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 14:31 [pbs-devel] " Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 1/6] accept a ref to a HttpClient Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 2/6] pull: refactor pulling from a datastore Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 3/6] pull: add support for pulling from local datastore Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 4/6] manager: add completion for opt. Remote in SyncJob Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 5/6] api: make Remote for SyncJob optional Hannes Laimer
2023-11-21 14:31 ` [pbs-devel] [PATCH proxmox-backup v6 6/6] ui: add support for optional Remote in SyncJob Hannes Laimer
2023-11-24 10:36 ` Lukas Wagner
2023-11-25 16:16 ` Thomas Lamprecht
2023-11-22 10:14 ` [pbs-devel] [PATCH proxmox-backup v6 0/6] local sync-jobs Gabriel Goller
2023-11-24 10:38 ` Lukas Wagner
2023-11-25 16:14 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97978cef-5b48-49c5-ab97-94154045b9dd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox