Re: [pbs-devel] [PATCH proxmox-backup] part fix 5560: client: periodically show backup progress

[Christian Ebner <c.ebner@proxmox.com>]

On 10/8/24 12:11, Gabriel Goller wrote:
> 
> One issue I encountered is that when having multiple archives, the 
> output is
> kind of messy, e.g.:
> 
>> root@pbs:~# PBS_REPOSITORY=test3 proxmox-backup-client backup 
>> root.pxar:. test.pxar:./something
>> Starting backup: host/pbs/2024-10-08T09:46:48Z
>> Client name: pbs
>> Starting backup protocol: Tue Oct  8 11:46:48 2024
>> No previous manifest available.
>> Upload directory '.' to 'test3' as root.pxar.didx
>>  root.pxar: elapsed 60.00 s, new: 13.077 GiB, reused: 0 B, total: 
>> 13.077 GiB, uploaded: 13.061 GiB (compressed 11.487 GiB, average: 
>> 222.902 MiB/s)
>>  catalog.pcat1: elapsed 60.00 s, new: 2.073 MiB, reused: 0 B, total: 
>> 2.073 MiB, uploaded: 2.073 MiB (compressed 911.743 KiB, average: 
>> 35.384 KiB/s)
>> root.pxar: had to backup 29.285 GiB of 29.294 GiB (compressed 27.707 
>> GiB) in 116.49 s (average 257.426 MiB/s)
>> root.pxar: backup was done incrementally, reused 8.493 MiB (0.0%)
>> Upload directory './something' to 'test3' as test.pxar.didx
>>  catalog.pcat1: elapsed 120.01 s, new: 2.073 MiB, reused: 0 B, total: 
>> 2.073 MiB, uploaded: 2.073 MiB (compressed 911.743 KiB, average: 
>> 17.692 KiB/s)
>>  root.pxar: elapsed 120.01 s, new: 29.285 GiB, reused: 8.493 MiB, 
>> total: 29.294 GiB, uploaded: 29.285 GiB (compressed 27.707 GiB, 
>> average: 249.891 MiB/s)  test.pxar: elapsed 60.00 s, new: 18.208 GiB, 
>> reused: 0 B, total: 18.208 GiB, uploaded: 18.194 GiB (compressed 
>> 18.194 GiB, average: 310.5 MiB/s)
>>  root.pxar: elapsed 180.01 s, new: 29.285 GiB, reused: 8.493 MiB, 
>> total: 29.294 GiB, uploaded: 29.285 GiB (compressed 27.707 GiB, 
>> average: 166.596 MiB/s)  catalog.pcat1: elapsed 180.01 s, new: 2.073 
>> MiB, reused: 0 B, total: 2.073 MiB, uploaded: 2.073 MiB (compressed 
>> 911.743 KiB, average: 11.795 KiB/s)
>> test.pxar: had to backup 22.304 GiB of 22.304 GiB (compressed 22.304 
>> GiB) in 73.81 s (average 309.419 MiB/s)
>> Uploaded backup catalog (2.287 MiB)
>> Duration: 190.40s
>> End Time: Tue Oct  8 11:49:58 2024
> 
> Note the last two "root.pxar ..." lines, they get printed after
> root.pxar has been uploaded and simply have the same numbers as the
> lines before (because obviously nothing has changed, everything is
> already uploaded).
> 
> But IMO if this is hard to fix, we can also leave it like this.

That is indeed not intended to happen. It should however be possible to 
fix by getting the join handle when spawning the task and abort it when 
the upload stream for the corresponding archive is terminated.

Will see if that works out and send a new version, thx!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel