From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stefan Sterz <s.sterz@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 1/1] ui: make panels in the dashboard all the same height
Date: Thu, 10 Mar 2022 11:15:44 +0100 [thread overview]
Message-ID: <963d159c-ebe2-e380-54ce-ff619c735364@proxmox.com> (raw)
In-Reply-To: <3269938a-6887-5dcd-bcde-fb158b7f15ab@proxmox.com>
On 10.03.22 11:13, Stefan Sterz wrote:
> On 10.03.22 10:31, Thomas Lamprecht wrote:
>> On 03.03.22 16:03, Stefan Sterz wrote:
>>> this fixes an issue where the layout looks misaligned in three column
>>> layouts
>>>
>>
>> imo it makes the layout look worse in the two column layout as there's a lot
>> of empty, odd looking space in the "Task Summary" and "Subscription" card.
>>
>> We could only change the running/longest task one, that'd fix the biggest
>> problem with the three column mode and still looks nice in the two-column
>> mode - what do you think?
>>
>
> yes they do look a bit awkward, if we fix both the longest and running
> tasks panels that works for me too. we could also set the height to
> 270 instead of 280, that would mean we have almost the same vertical
> height as before overall (off by 10) and it would make the
> "uptime/stats" look a bit nicer imho (getting rid of the whitespace
> "chin"). ill send a patch for that in a sec.
note that different translations can mean a line break in the stats panel,
IIRC that chin is there on purpose.
next prev parent reply other threads:[~2022-03-10 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 15:03 Stefan Sterz
2022-03-10 9:31 ` Thomas Lamprecht
2022-03-10 10:13 ` Stefan Sterz
2022-03-10 10:15 ` Thomas Lamprecht [this message]
2022-03-10 10:20 ` Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=963d159c-ebe2-e380-54ce-ff619c735364@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox