From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] pbs-datastore: lookup: don't create new ChunkStore on datastore reopen
Date: Fri, 3 Jun 2022 11:25:37 +0200 [thread overview]
Message-ID: <94d813c2-2443-0cb5-3400-e054e0909365@proxmox.com> (raw)
In-Reply-To: <20220602142744.548757-1-d.csapak@proxmox.com>
Am 02/06/2022 um 16:27 schrieb Dominik Csapak:
> When re-opening a datastore, e.g. because the config changed or the
> last re-open was >60s ago, the chunkstore was also re-opened. Opening a
> ChunkStore creates a new ProcessLocker, so re-opening a datastore had the
> unintentional side-effect of potentially discarding the existing
> ProcessLocker. Any contained shared locks are lost in turn.
>
> To fix this, reuse an old, existing ChunkStore (and its ProcessLocker)
> on the re-opened datastore, since only the datastore config should be
> reloaded, and the ChunkStore path is not updatable over our API anyway.
> If a user manually edited the path in the config, a daemon restart must
> happen for this change to take effect.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> pbs-datastore/src/datastore.rs | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>
>
forgot to reply yesterday: applied and backported, thanks!
prev parent reply other threads:[~2022-06-03 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 14:27 [pbs-devel] " Dominik Csapak
2022-06-03 9:25 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94d813c2-2443-0cb5-3400-e054e0909365@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox