From: Friedrich Weber <f.weber@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PATCH proxmox-backup v4] client: mount: wait for child to return before exiting
Date: Tue, 18 Jun 2024 16:45:47 +0200 [thread overview]
Message-ID: <94b4498c-356b-4826-bae5-3999b37192e7@proxmox.com> (raw)
In-Reply-To: <20240618140402.312627-1-g.goller@proxmox.com>
On 18/06/2024 16:03, Gabriel Goller wrote:
> When using the `proxmox-backup-client mount` command, the parent sometimes
> exits before we can print any error message. Most notably this happens
> when no PBS_REPOSITORY is passed, as this is the first option checked.
> If the underlying file descriptor has been closed, wait for the client
> to complete and return the error message.
>
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Suggested-by: Christian Ebner <c.ebner@proxmox.com>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
Can confirm this patch makes `sudo proxmox-backup-client mount foo bar
baz` print an error on every invocation, regardless of whether `Default
use_pty` is set in /etc/sudoers or not. Thanks!
Tested-by: Friedrich Weber <f.weber@proxmox.com>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-06-18 14:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 14:03 Gabriel Goller
2024-06-18 14:45 ` Friedrich Weber [this message]
2024-07-02 8:50 ` [pbs-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94b4498c-356b-4826-bae5-3999b37192e7@proxmox.com \
--to=f.weber@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox