From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 1/2] backup/datastore: refactor chunk inode sorting to the datastore
Date: Mon, 12 Jul 2021 06:23:06 +0200 [thread overview]
Message-ID: <94749d24-a501-2718-cf42-a6c42577b49a@proxmox.com> (raw)
In-Reply-To: <20210618092910.4518-1-d.csapak@proxmox.com>
On 18.06.21 11:29, Dominik Csapak wrote:
> so that we can reuse that information
>
> the removal of the adding to the corrupted list is ok, since
> 'get_chunks_in_order' returns them at the end of the list
> and we do the same if the loading fails later in 'verify_index_chunks'
> so we still mark them corrupt
> (assuming that the load will fail if the stat does)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> alternatively, we could return 2 lists, or check after the loop
> for the u64::MAX value, but imho it's ok this way
>
> src/backup/datastore.rs | 38 ++++++++++++++++++++++++++++++++++++++
> src/backup/verify.rs | 38 +++++++-------------------------------
> 2 files changed, 45 insertions(+), 31 deletions(-)
>
>
Just for the record, as Dietmar applied this on "Mon Jun 28 12:16:14 2021 +0200", but
I saw no applied mail and as you also still thought this was not in I figured it'll save
me some time in the future if I record that: applied, thanks!
prev parent reply other threads:[~2021-07-12 4:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 9:29 [pbs-devel] " Dominik Csapak
2021-06-18 9:29 ` [pbs-devel] [PATCH proxmox-backup 2/2] tape/helpers/snapshot_reader: sort chunks by inode (per index) Dominik Csapak
2021-06-18 15:02 ` Thomas Lamprecht
2021-07-12 4:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94749d24-a501-2718-cf42-a6c42577b49a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox