public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] superseded: [PATCH proxmox{, -backup} 0/4] unmount datastores after sync job
Date: Wed, 29 Oct 2025 17:02:18 +0100	[thread overview]
Message-ID: <93da1758-c49b-4723-9b28-dd2f40ae35d1@proxmox.com> (raw)
In-Reply-To: <20251014115357.81105-1-h.laimer@proxmox.com>

superseded-by: 
https://lore.proxmox.com/pbs-devel/20251029160103.241780-1-h.laimer@proxmox.com/T/#t

On 10/14/25 13:54, Hannes Laimer wrote:
> Adds the option to automatically unmount a datastore after a sync job
> finishes.
> 
> The idea is that, in combination with run-on-mount, it is possible to
> have datastores sync to external drives without the need to open the web
> ui or terminal. This came up a handful of times in support and a recent
> thread on the forum. Basically, also non-tech people could be tasked
> with plugging and unplugging different drives regularly and mounting,
> sync and unmounting would be done automatically.
> 
> Currently if any of the triggered jobs have the 'unmount-on-done' flag
> set the datastore will be unmounted right after the last of the
> triggered jobs finishes.
> 
> This seemed pretty straight forward and should be good in most use-cases
> I came up with. Also, I did consider having 'unmount-on-done' also for
> normally(schedule/manual) started jobs, I guess there could be some
> situations where that might useful. But, as I mentioned on the commit
> itself, we'd probably have to go through the command socket since sync jobs run
> on the proxy. And I did not think it adds that much, also not sure if
> we'd even want that.
> 
> proxmox:
> 
> Hannes Laimer (1):
>    pbs-api-types: add 'unmount-on-done' field to sync job config
> 
>   pbs-api-types/src/jobs.rs | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> 
> proxmox-backup:
> 
> Hannes Laimer (3):
>    api: syncjob: correctly update/delete 'unmount-on-done' field
>    api: datastore: unmount datastore after sync if configured
>    ui: add 'unmount-on-done' field to SyncJobEdit window
> 
>   src/api2/admin/datastore.rs | 21 +++++++++++++++++++--
>   src/api2/config/sync.rs     |  8 ++++++++
>   www/window/SyncJobEdit.js   | 23 +++++++++++++++++++++++
>   3 files changed, 50 insertions(+), 2 deletions(-)
> 
> 
> Summary over all repositories:
>    4 files changed, 58 insertions(+), 2 deletions(-)
> 



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      parent reply	other threads:[~2025-10-29 16:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14 11:53 [pbs-devel] " Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add 'unmount-on-done' field to sync job config Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 1/3] api: syncjob: correctly update/delete 'unmount-on-done' field Hannes Laimer
2025-10-29 13:24   ` Robert Obkircher
2025-10-29 13:37     ` Christian Ebner
2025-10-29 13:50       ` Christian Ebner
2025-10-29 13:51       ` Hannes Laimer
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 2/3] api: datastore: unmount datastore after sync if configured Hannes Laimer
2025-10-14 15:31   ` Shannon Sterz
2025-10-14 11:53 ` [pbs-devel] [PATCH proxmox-backup 3/3] ui: add 'unmount-on-done' field to SyncJobEdit window Hannes Laimer
2025-10-14 15:31   ` Shannon Sterz
2025-10-29 16:02 ` Hannes Laimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93da1758-c49b-4723-9b28-dd2f40ae35d1@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal