From: Christian Ebner <c.ebner@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs
Date: Mon, 4 Dec 2023 17:09:54 +0100 (CET) [thread overview]
Message-ID: <93719761.451.1701706194804@webmail.proxmox.com> (raw)
In-Reply-To: <1d497261-271e-4a07-8f79-3ef1e8508f77@proxmox.com>
> On 04.12.2023 16:42 CET Gabriel Goller <g.goller@proxmox.com> wrote:
>
> Small typo here... This should say `gcScheduleMsg`.
Ah yes, thanks for noticing, will be fixed in a new version.
> How about we put a green checkmark here (and on the other lines below)?
> Otherwise this wall of text looks kinda bleak :(
> We could add the `fa fa-check-circle` icon with the `good` (color:
> green) class?
Hmm, not to sure about that one, I deliberately did not emphasize the
message in case there are jobs configured, keeping the output rather
neutral. But I am open for opinions on this one.
However, I will include the question mark icon in case of the unknown
job config state. The main focus should be on possibly missing job
configurations, configured jobs might still have issues and need to be
checked in the tasks logs.
>
>
> There are also a few linting issues:
>
> 3 issues marked with (*) could be auto-fixed using '--fix'.
> [./datastore/Summary.js]:
> WARN: line 123 col 4: comma-dangle - Missing trailing comma. (*)
> WARN: line 138 col 4: comma-dangle - Missing trailing comma. (*)
> WARN: line 153 col 4: comma-dangle - Missing trailing comma. (*)
Yes, missed those as well, will be fixed in a new version.
Thank you for your comments!
next prev parent reply other threads:[~2023-12-04 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 14:01 Christian Ebner
2023-12-04 15:42 ` Gabriel Goller
2023-12-04 16:09 ` Christian Ebner [this message]
2023-12-05 10:22 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93719761.451.1701706194804@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox