From: Gabriel Goller <g.goller@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs
Date: Wed, 6 Dec 2023 10:07:19 +0100 [thread overview]
Message-ID: <936cd515-1d73-41d5-bb12-ee893750f3f3@proxmox.com> (raw)
In-Reply-To: <20231205101916.158756-1-c.ebner@proxmox.com>
On 12/5/23 11:19, Christian Ebner wrote:
> [..]
> @@ -115,6 +177,14 @@ Ext.define('PBS.DataStoreInfo', {
> });
> me.store.on('load', me.onLoad, me);
> },
> +
> + initComponent: function() {
> + let me = this;
> + let vm = me.getViewModel();
> + vm.set('gcScheduleMsg', me.fmtMissing(gettext('unknown')));
> + vm.set('pruneJobMsg', me.fmtMissing(gettext('unknown')));
> + vm.set('verifyJobMsg', me.fmtMissing(gettext('unknown')));
> + },
> },
`initComponent` won't be executed, because it is in a controller, not a
regular extjs component.
It works if you move these lines up to the `init()` function above.
> [..]
Otherwise it LGTM!
next prev parent reply other threads:[~2023-12-06 9:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 10:19 Christian Ebner
2023-12-06 9:07 ` Gabriel Goller [this message]
2023-12-06 11:16 ` Christian Ebner
2023-12-06 11:33 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=936cd515-1d73-41d5-bb12-ee893750f3f3@proxmox.com \
--to=g.goller@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox