* [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment
@ 2023-07-18 11:57 Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
2023-09-07 15:53 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-07-18 11:57 UTC (permalink / raw)
To: pbs-devel
The regular `textfield` does not support the `deleteEmpty`
setting. Thus, if no comment was entered the configuration
would still end up with an empty `comment` key:
ldap: foo
server ....
bind-dn ...
comment
Fixed by switching over to `proxmoxtextfield`, which properly
deletes empty keys.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
---
src/window/AuthEditLDAP.js | 2 +-
src/window/AuthEditOpenId.js | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
index 6aafb98..eb9700a 100644
--- a/src/window/AuthEditLDAP.js
+++ b/src/window/AuthEditLDAP.js
@@ -187,7 +187,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
columnB: [
{
- xtype: 'textfield',
+ xtype: 'proxmoxtextfield',
name: 'comment',
fieldLabel: gettext('Comment'),
cbind: {
diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
index 52a7521..ca84958 100644
--- a/src/window/AuthEditOpenId.js
+++ b/src/window/AuthEditOpenId.js
@@ -112,7 +112,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
columnB: [
{
- xtype: 'textfield',
+ xtype: 'proxmoxtextfield',
name: 'comment',
fieldLabel: gettext('Comment'),
cbind: {
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment
2023-07-18 11:57 [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment Lukas Wagner
@ 2023-09-01 6:55 ` Lukas Wagner
2023-09-07 15:53 ` [pbs-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2023-09-01 6:55 UTC (permalink / raw)
To: pbs-devel
Ping
On 7/18/23 13:57, Lukas Wagner wrote:
> The regular `textfield` does not support the `deleteEmpty`
> setting. Thus, if no comment was entered the configuration
> would still end up with an empty `comment` key:
>
> ldap: foo
> server ....
> bind-dn ...
> comment
>
> Fixed by switching over to `proxmoxtextfield`, which properly
> deletes empty keys.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 2 +-
> src/window/AuthEditOpenId.js | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js
> index 6aafb98..eb9700a 100644
> --- a/src/window/AuthEditLDAP.js
> +++ b/src/window/AuthEditLDAP.js
> @@ -187,7 +187,7 @@ Ext.define('Proxmox.panel.LDAPInputPanel', {
>
> columnB: [
> {
> - xtype: 'textfield',
> + xtype: 'proxmoxtextfield',
> name: 'comment',
> fieldLabel: gettext('Comment'),
> cbind: {
> diff --git a/src/window/AuthEditOpenId.js b/src/window/AuthEditOpenId.js
> index 52a7521..ca84958 100644
> --- a/src/window/AuthEditOpenId.js
> +++ b/src/window/AuthEditOpenId.js
> @@ -112,7 +112,7 @@ Ext.define('Proxmox.panel.OpenIDInputPanel', {
>
> columnB: [
> {
> - xtype: 'textfield',
> + xtype: 'proxmoxtextfield',
> name: 'comment',
> fieldLabel: gettext('Comment'),
> cbind: {
--
- Lukas
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pbs-devel] applied: Re: [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment
2023-07-18 11:57 [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
@ 2023-09-07 15:53 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-09-07 15:53 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Lukas Wagner
On 18/07/2023 13:57, Lukas Wagner wrote:
> The regular `textfield` does not support the `deleteEmpty`
> setting. Thus, if no comment was entered the configuration
> would still end up with an empty `comment` key:
>
> ldap: foo
> server ....
> bind-dn ...
> comment
>
> Fixed by switching over to `proxmoxtextfield`, which properly
> deletes empty keys.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 2 +-
> src/window/AuthEditOpenId.js | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-07 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-18 11:57 [pbs-devel] [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
2023-09-07 15:53 ` [pbs-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox