From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pbs-devel] applied: Re: [PATCH widget-toolkit] auth: ldap: openid: use proxmoxtextfield for comment
Date: Thu, 7 Sep 2023 17:53:26 +0200 [thread overview]
Message-ID: <91a37f3f-31ad-4b65-b58d-dd6bde986e3b@proxmox.com> (raw)
In-Reply-To: <20230718115707.452582-1-l.wagner@proxmox.com>
On 18/07/2023 13:57, Lukas Wagner wrote:
> The regular `textfield` does not support the `deleteEmpty`
> setting. Thus, if no comment was entered the configuration
> would still end up with an empty `comment` key:
>
> ldap: foo
> server ....
> bind-dn ...
> comment
>
> Fixed by switching over to `proxmoxtextfield`, which properly
> deletes empty keys.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/window/AuthEditLDAP.js | 2 +-
> src/window/AuthEditOpenId.js | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-09-07 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:57 [pbs-devel] " Lukas Wagner
2023-09-01 6:55 ` Lukas Wagner
2023-09-07 15:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91a37f3f-31ad-4b65-b58d-dd6bde986e3b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox