public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pbs-devel] applied: [REBASED v2 backup 0/9] rebased and reordered acme implementation
Date: Tue, 4 May 2021 09:57:32 +0200	[thread overview]
Message-ID: <918688a1-7e66-0ded-80ea-72f5746cb9bc@proxmox.com> (raw)
In-Reply-To: <20210503093959.14855-1-w.bumiller@proxmox.com>

applied with minor cleanups

On 5/3/21 11:39 AM, Wolfgang Bumiller wrote:
> Only minor changes, a split and some merges:
>
> * moved the validation plugin implementations from config::acme::plugin
>    to acme::plugin, in order to separate the config again.
> * dropped the `read_lock` functions and renamed `write_lock` -> `lock`
> * removed some leftover commented out code
> * changed lock timeouts to 10s like in most other config parts
> * lock file name consistency ('.lock' -> '.lck')
> * kept AccountName for now, we still need to discuss how to
>    approach this definitively
> * for less noise I merged the patches at the end of the series into the
>    earlier ones, since they're mostly fixup commits:
>    - creating acme directories before placing files in there
>    - validate config before writing
>    - pipe plugin output to task log
>    - make account name optional in api call
>    Also: standalone validation, since introducing dns validation together
>    with the plugin config but adding this one later isn't consistent
>    anyway.
>
> Wolfgang Bumiller (9):
>    add acme config
>    add acme client
>    add node config
>    add config/acme api path
>    add node/{node}/certificates api call
>    add node/{node}/config api path
>    add acme commands to proxmox-backup-manager
>    ui: add certificate & acme view
>    daily-update: check acme certificates
>
>   src/acme/client.rs                     | 673 +++++++++++++++++++++++
>   src/acme/mod.rs                        |   5 +
>   src/acme/plugin.rs                     | 299 ++++++++++
>   src/api2/config.rs                     |   2 +
>   src/api2/config/acme.rs                | 725 +++++++++++++++++++++++++
>   src/api2/node.rs                       |   4 +
>   src/api2/node/certificates.rs          | 579 ++++++++++++++++++++
>   src/api2/node/config.rs                |  80 +++
>   src/bin/proxmox-backup-manager.rs      |   1 +
>   src/bin/proxmox-daily-update.rs        |  30 +-
>   src/bin/proxmox_backup_manager/acme.rs | 415 ++++++++++++++
>   src/bin/proxmox_backup_manager/mod.rs  |   2 +
>   src/config.rs                          |  20 +-
>   src/config/acme/mod.rs                 | 273 ++++++++++
>   src/config/acme/plugin.rs              | 213 ++++++++
>   src/config/node.rs                     | 202 +++++++
>   src/lib.rs                             |   2 +
>   www/Makefile                           |   1 +
>   www/NavigationTree.js                  |   6 +
>   www/config/CertificateView.js          |  80 +++
>   20 files changed, 3609 insertions(+), 3 deletions(-)
>   create mode 100644 src/acme/client.rs
>   create mode 100644 src/acme/mod.rs
>   create mode 100644 src/acme/plugin.rs
>   create mode 100644 src/api2/config/acme.rs
>   create mode 100644 src/api2/node/certificates.rs
>   create mode 100644 src/api2/node/config.rs
>   create mode 100644 src/bin/proxmox_backup_manager/acme.rs
>   create mode 100644 src/config/acme/mod.rs
>   create mode 100644 src/config/acme/plugin.rs
>   create mode 100644 src/config/node.rs
>   create mode 100644 www/config/CertificateView.js
>




      parent reply	other threads:[~2021-05-04  7:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03  9:39 [pbs-devel] " Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 1/9] add acme config Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 2/9] add acme client Wolfgang Bumiller
2021-05-04  6:10   ` Dietmar Maurer
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 3/9] add node config Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 4/9] add config/acme api path Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 5/9] add node/{node}/certificates api call Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 6/9] add node/{node}/config api path Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 7/9] add acme commands to proxmox-backup-manager Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 8/9] ui: add certificate & acme view Wolfgang Bumiller
2021-05-03  9:39 ` [pbs-devel] [REBASED v2 backup 9/9] daily-update: check acme certificates Wolfgang Bumiller
2021-05-04  7:57 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=918688a1-7e66-0ded-80ea-72f5746cb9bc@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal