From: Hannes Laimer <h.laimer@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox/proxmox-backup] add 'pbs-shell' tool
Date: Mon, 13 Sep 2021 11:36:30 +0200 [thread overview]
Message-ID: <9128b335-2f1b-5390-57c4-72f36051d8b9@proxmox.com> (raw)
In-Reply-To: <20210909134819.2082605-1-d.csapak@proxmox.com>
I just noticed two things while testing:
- if an endpoint expects a parameter called 'path'(e.g. POST /config
/datastore), the parameter conflicts with the api path itself
- even though commands like verify(POST /admin/datastore/<name>/verify)
or gc(POST /admin/datastore/<name>/gc) are started and run successfully,
`Error: control socket connect failed - Connection refused (os error
111)` is displayed almost always at the end.
Note: For testing I applied the patches on
b65dfff574f44e5a60db3903d2226f4dbe386b7a, I assume the moving of stuff
after that should not effect the functionality
Am 09.09.21 um 15:48 schrieb Dominik Csapak:
> this series adds the tool 'pbs-shell', similar to 'pvesh' and 'pmgsh'
> this tool is intended mainly for debugging, but can be useful for
> api calls not exposed via the client/manager.
>
> proxmox (and the dependency in proxmox-backup) need to be bumped
>
> proxmox-backup patches 2-5 are not strictly necessary, but improve
> the api so that the 'ls' command works better
> (there are still some api paths to be fixed)
>
> proxmox:
>
> Dominik Csapak (1):
> proxmox: generate_usage_str: don't require static lifetimes
>
> proxmox/src/api/cli/format.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> proxmox-backup:
>
> Dominik Csapak (5):
> add 'pbs-shell' utility
> api2: add missing token list match_all property
> api2: disks/directory: refactor BASE_MOUNT_DIR
> api2: disks/directory: add 'name' property to directory mount listing
> api2: nodes: add missing node list api call
>
> Makefile | 2 +
> debian/pbs-shell.bc | 3 +
> debian/proxmox-backup-server.bash-completion | 1 +
> debian/proxmox-backup-server.install | 3 +
> docs/Makefile | 8 +
> docs/pbs-shell/description.rst | 3 +
> docs/pbs-shell/man1.rst | 40 ++
> src/api2/access/user.rs | 35 +-
> src/api2/mod.rs | 4 +-
> src/api2/node/disks/directory.rs | 15 +-
> src/api2/node/mod.rs | 12 +-
> src/bin/pbs-shell.rs | 502 +++++++++++++++++++
> zsh-completions/_pbs-shell | 13 +
> 13 files changed, 628 insertions(+), 13 deletions(-)
> create mode 100644 debian/pbs-shell.bc
> create mode 100644 docs/pbs-shell/description.rst
> create mode 100644 docs/pbs-shell/man1.rst
> create mode 100644 src/bin/pbs-shell.rs
> create mode 100644 zsh-completions/_pbs-shell
>
next prev parent reply other threads:[~2021-09-13 9:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 13:48 Dominik Csapak
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox 1/1] proxmox: generate_usage_str: don't require static lifetimes Dominik Csapak
2021-09-15 7:40 ` [pbs-devel] applied: " Thomas Lamprecht
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox-backup 1/5] add 'pbs-shell' utility Dominik Csapak
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox-backup 2/5] api2: add missing token list match_all property Dominik Csapak
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox-backup 3/5] api2: disks/directory: refactor BASE_MOUNT_DIR Dominik Csapak
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox-backup 4/5] api2: disks/directory: add 'name' property to directory mount listing Dominik Csapak
2021-09-09 13:48 ` [pbs-devel] [PATCH proxmox-backup 5/5] api2: nodes: add missing node list api call Dominik Csapak
2021-09-15 9:44 ` [pbs-devel] applied: " Thomas Lamprecht
2021-09-13 9:36 ` Hannes Laimer [this message]
2021-09-13 10:38 ` [pbs-devel] [PATCH proxmox/proxmox-backup] add 'pbs-shell' tool Dominik Csapak
2021-09-15 5:25 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9128b335-2f1b-5390-57c4-72f36051d8b9@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox