public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-rrd] cache: skip non-utf8 lines in rrd journal
Date: Mon, 24 Jun 2024 19:30:55 +0200	[thread overview]
Message-ID: <9114c156-ef5a-4ca1-8383-14dc087fe815@proxmox.com> (raw)
In-Reply-To: <1897229403.670.1719244415488@webmail.proxmox.com>

On 6/24/24 17:53, Dietmar Maurer wrote:
>> In certain situations garbage might be written to the rrd journal,
>> e.g. by a hard crash of the host.
> 
> Why does a host crash writes garbage to a file?

I did not investigate any further how the file corruption might have 
occurred: might be truncated output leading to incorrect, non-utf8 
encoding before the full line was written?

Nevertheless, the reported error message points to this location and the 
line should be skipped if not correctly encoded, no matter how the file 
was corrupted to begin with. Otherwise the mentioned issues arise.


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel




  reply	other threads:[~2024-06-24 17:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24 14:24 Christian Ebner
2024-06-24 15:53 ` Dietmar Maurer
2024-06-24 17:30   ` Christian Ebner [this message]
2024-06-28 12:09     ` Wolfgang Bumiller
2024-06-28 12:20       ` Christian Ebner
2024-06-28 12:25         ` Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9114c156-ef5a-4ca1-8383-14dc087fe815@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=dietmar@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal