From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix: ui: spinner position
Date: Mon, 16 Oct 2023 13:57:41 +0200 [thread overview]
Message-ID: <907a68a9-5a68-4631-9a70-b13e570e3cf8@proxmox.com> (raw)
In-Reply-To: <1d8ff790-3e6c-435d-a58d-5a7ab32245fb@proxmox.com>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On 10/16/23 12:04, Thomas Lamprecht wrote:
> [..]
> To clarify, I'd explicitly only left-align those spinners for when
> used as job running spinners, not for loading – and IIRC we do not
> have any per-cell or per-row loading indicators anyway, as we always
> load all data of a grid at once (or at least fake doing so), but never
> row or even cell-wise.
Oh, ok, got it.
> So moving this new alignment behavior into its own class, that derives
> from the ExtJS one, seems more reasonable to avoid odd rendering issues
> for the cases where the left-alignment isn't desired.
>
> If we then add a text to that is an independent decision, but it surely
> wouldn't hurt accessibility.
Ok, so I think I'll move the current `x-grid-row-loading` class to the
`proxmox-widget-toolkit/src/css/ext-6-pmx.css` file and create a new
class `x-grid-row-loading-left` (with the 10px margin left). I'll also
have to edit the `proxmox-dark/*.scss` files so that the logo is shown
correctly in the darkmode. To add the text I would simply return a `<span>`
tag with a margin left of 20px (more or less, to make place for the icon)
and have the translated text as a content.
Returning the icon directly as a `<img>` tag isn't that simple, I'd had to
attach the whole styling + the conditional dark mode stuff.
LMK what you think!
[-- Attachment #2: Type: text/html, Size: 2051 bytes --]
next prev parent reply other threads:[~2023-10-16 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 14:20 Gabriel Goller
2023-10-11 11:06 ` Gabriel Goller
2023-10-12 9:28 ` Dominik Csapak
2023-10-12 11:49 ` Gabriel Goller
2023-10-12 12:34 ` Dominik Csapak
2023-10-12 12:40 ` Gabriel Goller
2023-10-13 12:38 ` Thomas Lamprecht
2023-10-13 13:04 ` Dominik Csapak
2023-10-16 9:51 ` Gabriel Goller
2023-10-16 10:04 ` Thomas Lamprecht
2023-10-16 11:57 ` Gabriel Goller [this message]
2023-10-16 12:41 ` Gabriel Goller
2023-10-18 10:09 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907a68a9-5a68-4631-9a70-b13e570e3cf8@proxmox.com \
--to=g.goller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox