From: Christian Ebner <c.ebner@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] api: list-snapshots improvements
Date: Wed, 3 Jul 2024 16:00:02 +0200 (CEST) [thread overview]
Message-ID: <903050964.3732.1720015202719@webmail.proxmox.com> (raw)
In-Reply-To: <20240703135512.qasjmnjnmrsqlupd@luna.proxmox.com>
> On 03.07.2024 15:55 CEST Gabriel Goller <g.goller@proxmox.com> wrote:
>
>
> On 03.07.2024 15:46, Christian Ebner wrote:
> >Hi, some initial high level comments, did not test this just yet.
> >
> >You touch several completely unrelated thing in this patch. I feel that this should be split into at least 3-4 patches:
>
> Sure, I can do that. I just didn't want to pollute the mailing list with
> a bunch of one-line fixes :)
But each of these warrants its own patch. Furhter, that allows to selectively apply them.
>
> >- fixing the typo
> >- removing the unsafe block (although this feels like Wolfgang did this on purpose to make a caller aware of possible consequences, see commit message for a577d7d8).
> >- avoid double retrial of protected flag, (can we also assure that this is not done on purpose, to avoid possible races?)
> >- refactor of `full_path`
> >
> >Also, can you see a noticeable difference in listing time for groups with a larger number of backups?
> >Please give some ballpark figures if so.
>
> Hmm yeah, I can write some benchmarks quickly, shouldn't be a lot
> though, some 100-200 ms maybe.
Absolute values have no meaning in this regard, as this depends on the number of snapshots in the group. You should give a relative estimate.
Also, my intention was not for you to have to write extra performance tests just for this ;)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-07-03 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 13:16 Gabriel Goller
2024-07-03 13:46 ` Christian Ebner
2024-07-03 13:55 ` Gabriel Goller
2024-07-03 14:00 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=903050964.3732.1720015202719@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox