public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE user list <pve-user@lists.proxmox.com>,
	Cornelius Hoffmann <c.hoffmann@fu-berlin.de>,
	pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [PVE-User] pbs - Nasty atime bug in Ubuntu's kernel-builtin zfs
Date: Wed, 16 Oct 2024 17:56:35 +0200	[thread overview]
Message-ID: <8fe24024-9416-45af-9d7a-d53dceee5543@proxmox.com> (raw)
In-Reply-To: <a65b8433-c6d0-4179-977a-be677f98441a@fu-berlin.de>

Hello,

Am 16/10/2024 um 17:06 schrieb Cornelius Hoffmann:
> I ran in to a very nasty bug with the zfs version included in Ubuntu 
> (NOT the pbs default kernel, I'm running PBS in a container), which is 
> the base for Proxmox as well as far as I understand it and wanted to 
> warn about a problem with access times that is encountered there.
> 
> Essentially, this is [1] and it causes the access time update of a 
> `touch` command to fail and set it to epoch 0, so Jan 1, 1970. This will 
> cause all chunks that should not be pruned to have an extremely old 
> atime and thus be pruned, causing a corruption of all backups.
> 
> I'm writing here to make sure there is not maybe a kernel update waiting 
> with these changes. The newest zfs-linux version in noble has the bug 
> fixed as it includes [2], but that change is only visible in the dkms 
> module, which I installed to fix this problem in the meantime.

Thanks for reaching out to us, but please note that Proxmox maintains
its own ZFS downstream package for both user-space tools and kernel
module.

Both the bad commit and the fix were in ZFS 2.2.3 [0], and unlike Ubuntu
we never backported the problematic commit manually, so the Proxmox
kernel and its ZFS module were never affected, FWICT.

I also tried the reproducer, as it is simple enough and just to be sure,
and I could _not_ observe the broken behavior from ZFS.

[0]: https://github.com/openzfs/zfs/releases/tag/zfs-2.2.3

regards,
 Thomas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2024-10-16 15:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 15:06 [pbs-devel] " Cornelius Hoffmann
2024-10-16 15:56 ` Thomas Lamprecht [this message]
2024-10-16 17:05   ` [pbs-devel] [PVE-User] " Cornelius Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fe24024-9416-45af-9d7a-d53dceee5543@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.hoffmann@fu-berlin.de \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pve-user@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal