Re: [PATCH proxmox 3/3] pbs-api-types: zfs: define schema for recordsize

[Nicolas Frey <n.frey@proxmox.com>]

when using the CLI, this currently creates a zpool even though the
validation *should* fail. e.g. the following command:

proxmox-backup-manager disk zpool create test1 \
	--devices sdc --raidlevel single --recordsize=12

prints this error:

command "zfs" "set" "recordsize=12" "relatime=on" "test1" failed -
status code: 255 - cannot set property for 'test1': 'recordsize' must
be power of 2 from 512B to 16M

but still creates a zfs pool with the default 128K record size.

On 8/4/26 2:40 PM, Shan Shaji wrote:
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  pbs-api-types/src/zfs.rs | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/pbs-api-types/src/zfs.rs b/pbs-api-types/src/zfs.rs
> index 2cfbd403..3cfb9f8f 100644
> --- a/pbs-api-types/src/zfs.rs
> +++ b/pbs-api-types/src/zfs.rs
> @@ -6,6 +6,7 @@ use proxmox_schema::*;
>  
>  const_regex! {
>      pub ZPOOL_NAME_REGEX = r"^[a-zA-Z][a-z0-9A-Z\-_.:]+$";
> +    ZFS_RECORD_SIZE_REGEX = r"^(?i)([1-9][0-9]*)([km])?$";
>  }
>  
>  pub const ZFS_ASHIFT_SCHEMA: Schema = IntegerSchema::new("Pool sector size exponent.")
> @@ -18,6 +19,10 @@ pub const ZPOOL_NAME_SCHEMA: Schema = StringSchema::new("ZFS Pool Name")
>      .format(&ApiStringFormat::Pattern(&ZPOOL_NAME_REGEX))
>      .schema();
>  
> +pub const ZFS_RECORD_SIZE_SCHEMA: Schema = StringSchema::new("ZFS Recordsize. Use numbers with optional k or m suffix (e.g., 128k).")
> +    .format(&ApiStringFormat::Pattern(&ZFS_RECORD_SIZE_REGEX))

consider using `ApiStringFormat::VerifyFn` to verify the record size,
analagous to the one you have in javascript

> +    .schema();
> +
>  #[api(default: "On")]
>  #[derive(Debug, Copy, Clone, PartialEq, Eq, Serialize, Deserialize)]
>  #[serde(rename_all = "lowercase")]