public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v3 0/3] add rest_server example
Date: Wed, 29 Sep 2021 09:49:15 +0200	[thread overview]
Message-ID: <8ef4412a-fc57-77ff-763d-f9d8ea748e45@proxmox.com> (raw)
In-Reply-To: <20210929070420.617226-1-d.csapak@proxmox.com>

On 29.09.21 09:04, Dominik Csapak wrote:
> adds a rest_server example to the proxmox-rest-server crate.
> 
> changes from v2:
> * don't use pbs_runtime, but use a stock tokio runtime (cuts the
>   pbs-runtime dependency)
> * improve commit messages (explain hyper addrincoming, and api call
>   paths)
> * use proxmox "0.13" dev-dependency instead of "0.13.5"
> * use explicit hyper version dependency (0.14.5)
> 
> changes from v1:
> * added patches so we can remove the (now) unused srt/tools/async_io.rs.
>   this enables us to don't have any dependencies on the top-level crate
>   for the example, and we can move it into proxmox-rest-server
> * use hypers AddrStream for the example
> 
> Dominik Csapak (4):
>   rest-server: use hypers AddrIncoming for proxmox-backup-api
>   remove tools/async_io.rs
>   examples: add example for a simple rest server with a small api
>   fixup! rest-server: use hypers AddrIncoming for proxmox-backup-api
> 
>  proxmox-rest-server/Cargo.toml              |   7 +-
>  proxmox-rest-server/examples/rest_server.rs | 220 ++++++++++++++++++++
>  proxmox-rest-server/src/rest.rs             |  18 +-
>  src/bin/proxmox-backup-api.rs               |   3 +-
>  src/tools/async_io.rs                       |  83 --------
>  src/tools/mod.rs                            |   1 -
>  6 files changed, 236 insertions(+), 96 deletions(-)
>  create mode 100644 proxmox-rest-server/examples/rest_server.rs
>  delete mode 100644 src/tools/async_io.rs
> 



applied, thanks! FYI: I `rebase --fixup`'d the series and renamed the example to
minimal-rest-server for now.




      parent reply	other threads:[~2021-09-29  7:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  7:04 [pbs-devel] " Dominik Csapak
2021-09-29  7:04 ` [pbs-devel] [PATCH proxmox-backup v3 1/4] rest-server: use hypers AddrIncoming for proxmox-backup-api Dominik Csapak
2021-09-29  7:04 ` [pbs-devel] [PATCH proxmox-backup v3 2/4] remove tools/async_io.rs Dominik Csapak
2021-09-29  7:04 ` [pbs-devel] [PATCH proxmox-backup v3 3/4] examples: add example for a simple rest server with a small api Dominik Csapak
2021-09-29  7:04 ` [pbs-devel] [PATCH proxmox-backup v3 4/4] fixup! rest-server: use hypers AddrIncoming for proxmox-backup-api Dominik Csapak
2021-09-29  7:07   ` Dominik Csapak
2021-09-29  7:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ef4412a-fc57-77ff-763d-f9d8ea748e45@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal