Re: applied: [PATCH proxmox-backup] chunk store: s3: mute warning on overwrite empty chunk in local cache

[Christian Ebner <c.ebner@proxmox.com>]

On 3/5/26 9:51 AM, Fabian Grünbichler wrote:
> 
> On Wed, 04 Mar 2026 11:36:00 +0100, Christian Ebner wrote:
>> For regular datastores overwriting chunks which have 0 size is
>> unexpected and cannot happen under regular operation. For datastores
>> backed by an S3 object storage, this is however expected as regular
>> operation if the cache reaches its capacity, since chunks get evicted
>> from the cache by leaving an empty file as chunk marker behind.
>>
>> While the warning is benign, it causes false alerts in the task logs.
>> Therefore, silence the warning if the chunk insert overwriting the
>> file happens via the local datastore cache.
>>
>> [...]
> 
> Applied, thanks!
> 
> Might be something to consider when refactoring the whole datastore/chunkstore
> interaction with a proper locked wrapper and integrating the backend - this
> could then be derived from the backend?

Yes, although if we do keep the working principle for the cache as is, a 
chunk insert overwriting an empty file will be regular operation, 
independent on the actual chunk store backend.

Backend implementation and local cache should not be intertwined to much 
I think? We might reuse this for other backend implementations?