public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>, Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pbs-devel] [RFC v2 proxmox-backup] create prune simulator
Date: Thu, 29 Oct 2020 17:11:26 +0100	[thread overview]
Message-ID: <8e8ff26a-0750-463b-149f-e7014ccf170c@proxmox.com> (raw)
In-Reply-To: <20201028131206.23593-1-f.ebner@proxmox.com>

On 28.10.20 14:12, Fabian Ebner wrote:
> A stand-alone ExtJS app that allows experimenting with
> different backup schedules and prune parameters.
> 
> For performance reasons, the week table does not use
> subcomponents, but raw HTML.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * add list view of backups as we have in PBS
>     * make it possible to toggle the calendar and hide it by default
>     * make it possible to toggle the colors and turn them off by default
>     * fix backup sorting and uniqueness when there is more than one start time
>     * add a button for applying a new schedule instead of doing so continuosly
>     * make it more obvious that one can input a custom schedule
>     * error out on invalid schedule inputs
>     * make the number of weeks configurable
>     * show which rule keeps a specific backup
>     * keep all if all options are zero
>     * minor style improvements
> 

I find it pretty nice now, great job!


I'd only reorder it a bit, make it a full-page application and add some prune/schedule
documentation - we could maybe just pull that 1:1 from the docs html output or
something, it hasn't to be extra long just a short widget explanation and some other
info which would assist users to understand the concepts and plan their schedule
interactively.

I.e., something like the following layout:

+--------------------------------------------------+--------------------------+
|                                                  |                          |
|  Simulated                                       |                          |
|  Backup Schedule                                 |       Documentation      |
|                                                  |                          |
+-------------------------+------------------------+  * What this widget is   |
|                         |                        |                          |
|  Prune keep settings    |   Prune "keep" view    |  * prune params explained|
|                         |                        |                          |
|                         |                        |  * ...                   |
|                         |                        |                          |
|                         |                        |                          |
+-------------------------+------------------------+                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                     Calendar                     |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
|                                                  |                          |
+--------------------------------------------------+--------------------------+


But in any way, I like it a lot more than v1, and that wasn't bad either :)






      reply	other threads:[~2020-10-29 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 13:12 Fabian Ebner
2020-10-29 16:11 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e8ff26a-0750-463b-149f-e7014ccf170c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal