Re: [pbs-devel] [PATCH proxmox-backup/pwt 0/14] fix #5379: introduce default auth realm option

[Lukas Wagner <l.wagner@proxmox.com>]

On  2024-08-08 16:25, Christoph Heiss wrote:
> Following up on this: PVE has the exact same behaviour. The login dialog
> component (`Proxmox.form.RealmComboBox`, living in
> proxmox-widget-toolkit) is in fact reused between both frontends.

ah yeah, I think I tried to reproduce this on PVE *before* I fully realized
to exact steps to trigger it...

> 
> PVE uses the key `ext-pveloginrealm` in local storage, PBS
> `ext-pbs-pveloginrealm`.
> 
> So IMHO either we should keep the behaviour as-is or change it for both,
> the latter preferably as a separate changeset.
> 
> I would even argue to keep the behaviour, since it makes sense to me -
> if a user once logs in using a specific realm, he will probably want to
> *always* log in with that realm.
> 
> What do you think?

Intuitively I'd expect this feature to work the other way round:
  - If a default is set, select that one
  - If not, take the one that was previously selected
  - fallback to PAM

The current behavior definitely took my by surprise.

But I think this is a matter of taste, so other opinions would
be valuable here as well. Whichever approach we choose, a short
paragraph in the docs would definitely be a good idea :)

-- 
- Lukas


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel